Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES|QL controls] Design cleanup #1 #37

Merged
merged 4 commits into from
Jan 17, 2025

Conversation

andreadelrio
Copy link

Summary

  • Adjusted heading size in flyout
  • Updated the color and size of callout in the query is returning more than one column scenario. Color changed from primary to warning.
image
  • Updated the style of the Values preview panel (to primary background) to prevent it from looking too much like an interactive input.
image
  • Aligned the "here" link with the rest of the callout text.
  • Fixed styling of Optional text in inputs.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@andreadelrio andreadelrio changed the title [Es|QL controls] Design cleanup #1 [ES|QL controls] Design cleanup #1 Jan 10, 2025
Copy link
Owner

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome ❤️

@stratoula stratoula merged commit 5ecf596 into stratoula:esql-controls Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants