-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardising Page Builders - Elementor #3144
base: dev
Are you sure you want to change the base?
Conversation
'pmpro_invert_restrictions', array( | ||
'type' => \Elementor\Controls_Manager::SELECT, | ||
'options' => array( | ||
'0' => esc_html__( 'Show content to...', 'textdomain' ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'textdomain' instances need to be updated to 'paid-memberships-pro'
We also need to add backwards compatibility to this logic. The data is available but lost when upgrading to this script because of the new settings added, once changing to "Specific Membership Levels" it shows - we can automate this by checking for the values for backwards compatibility. It does need a bit more thought. |
All Submissions:
Changes proposed in this Pull Request:
Standardises how our page builder settings look, using the same controls throughout.
How to test the changes in this Pull Request:
Other information: