Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardising Page Builders - Elementor #3144

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

JarrydLong
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Standardises how our page builder settings look, using the same controls throughout.

image

How to test the changes in this Pull Request:

  1. Create a page or post and edit in Elementor. Add an element
  2. Click on the Advanced tab and then on the Paid Memberships Pro tab
  3. Adjust settings as needed

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

'pmpro_invert_restrictions', array(
'type' => \Elementor\Controls_Manager::SELECT,
'options' => array(
'0' => esc_html__( 'Show content to...', 'textdomain' ),
Copy link
Contributor

@andrewlimaza andrewlimaza Jan 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'textdomain' instances need to be updated to 'paid-memberships-pro'

@andrewlimaza
Copy link
Contributor

We also need to add backwards compatibility to this logic. The data is available but lost when upgrading to this script because of the new settings added, once changing to "Specific Membership Levels" it shows - we can automate this by checking for the values for backwards compatibility. It does need a bit more thought.

@dparker1005 dparker1005 added this to the 3.4 milestone Jan 8, 2025
@dparker1005 dparker1005 marked this pull request as ready for review January 15, 2025 16:05
@dparker1005 dparker1005 removed this from the 3.4 milestone Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants