Upgrade to Storybook 8 #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rename "register" directory to "manager" - remove root *.js entries for compiled entries to dist instead, like src/register-panel.ts - set correct export maps for exported entries - upgrade packages - set optional peer dependencies needed when using the blocks from this package
Closed
5 tasks
JReinhold
added
major
JReinhold
commented
Mar 13, 2024
Comment on lines
63
to
69
| "peerDependencies": { | ||
| "@storybook/addon-docs": "^8.0.0-alpha.10 || ^8.0.0", | ||
| "@storybook/components": "^8.0.0-alpha.10 || ^8.0.0", | ||
| "@storybook/manager-api": "^8.0.0-alpha.10 || ^8.0.0", | ||
| "@storybook/preview-api": "^8.0.0-alpha.10 || ^8.0.0", | ||
| "@storybook/theming": "^8.0.0-alpha.10 || ^8.0.0", | ||
| "react": "^16.8.0 || ^17.0.0 || ^18.0.0", | ||
| "react-dom": "^16.8.0 || ^17.0.0 || ^18.0.0" | ||
| "@storybook/blocks": "^8.0.0", | ||
| "@storybook/components": "^8.0.0", | ||
| "@storybook/theming": "^8.0.0", | ||
| "react": "^18.2.0", | ||
| "react-dom": "^18.2.0" | ||
| }, |
There was a problem hiding this comment.
These are only needed by users if they intend to use the doc blocks this package provides.
|
@JReinhold: Out of the 13 reported issues, how many would you consider helpful and valuable? And a second question: I think, most errors might not have been reported if TypeScript had been set up stricter (strict mode, for example). Is that the case? |
|
@valentinpalkovic quickly looking through them, they would all have been caught by a stricter TypeScript mode, so I don't find this specific scenario useful, except for anything else than "you should make your TS config more strict". |
|
I have tried 8.0.0--canary.232.785af00.0 and it works fine afaics. ❤️ |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #231, #229
This PR does a lot of things:
examplesandexamples-tabStorybooks into a single Storybook, while still maintaining their separation of/for examples and/tab/for tab examplesTodo
📦 Published PR as canary version:
8.0.0--canary.232.a463deb.0✨ Test out this PR locally via: