Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pb: Config service added: minimum selection version for upload added. #10

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Qweder93
Copy link
Contributor

@Qweder93 Qweder93 commented Jun 1, 2021

Change-Id: I2fdf1b1a5555e102c8f9a53af0d18b54786d23e7

What: added minimum selection version to nodestats

Why: all minimum selection versions from trusted satellites will be compared and newest version will be shown
as version on which node still won't be disqualified, but would not receive new data, just storing.

Please describe the tests:

  • Test 1:
  • Test 2:

Please describe the performance impact:

Code Review Checklist (to be filled out by reviewer)

  • NEW: Are there any Satellite database migrations? Are they forwards and backwards compatible?
  • Does the PR describe what changes are being made?
  • Does the PR describe why the changes are being made?
  • Does the code follow our style guide?
  • Does the code follow our testing guide?
  • Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
  • Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
  • Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
  • Does any documentation need updating?
  • Do the database access patterns make sense?

@rikysya rikysya changed the title pb: nodestats extended with minimum version for satellite pb: nodestats extended with selection minimum version Jun 1, 2021
@Qweder93 Qweder93 requested review from rikysya and crawter June 1, 2021 12:04
Copy link
Member

@egonelbre egonelbre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no description on why and how this will be used.

Similarly this would fragment where minimum version is defined. The satellite does not know this information.

pb/nodeselection.proto Outdated Show resolved Hide resolved
pb/nodeselection.proto Outdated Show resolved Hide resolved
pb/nodeselection.proto Outdated Show resolved Hide resolved
@Qweder93 Qweder93 requested a review from egonelbre June 1, 2021 15:24
@Qweder93 Qweder93 changed the title pb: nodestats extended with selection minimum version pb: Config service added: minimum selection version for upload added. Jun 1, 2021
@egonelbre
Copy link
Member

@Qweder93 I adjusted the naming a bit.

@egonelbre egonelbre requested review from kaloyan-raev and removed request for egonelbre June 3, 2021 09:41
@egonelbre egonelbre dismissed their stale review June 3, 2021 09:42

was involved in design

Change-Id: I2fdf1b1a5555e102c8f9a53af0d18b54786d23e7
@Erikvv
Copy link
Contributor

Erikvv commented Feb 3, 2022

Is this still relevant?


message MinimumStorageNodeResponse {
// upload is the minimum storage node version that are considered for uploading data.
node.NodeVersion upload = 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per the PR description

all minimum selection versions from trusted satellites will be compared and newest version will be shown
as version on which node still won't be disqualified, but would not receive new data, just storing."

The name "upload" seems the opposite of this, we usually call this download. To avoid this ambiguity maybe call it "storeNewPieces"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants