Skip to content

configure.ac: fix bashism #1111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025
Merged

Conversation

thesamesam
Copy link
Contributor

configure scripts run with a #!/bin/sh shebang which means they should work with a POSIX shell, so avoid using '+=' which is a bashism.

configure scripts run with a #!/bin/sh shebang which means they should work
with a POSIX shell, so avoid using '+=' which is a bashism.
Copy link
Collaborator

@vpodzime vpodzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@vojtechtrefny
Copy link
Member

Jenkins, ok to test.

Copy link
Member

@vojtechtrefny vojtechtrefny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@vpodzime
Copy link
Collaborator

ci_unstable/x86_64/centos_9s — Build and unstable tests finished: failure
ci_unstable/x86_64/centos_10s
ci_unstable/x86_64/centos_10s — Build and unstable tests finished: failure
ci/x86_64/f_rawhide
ci/x86_64/f_rawhide — Build and tests finished: failure

No related failures.

@vpodzime vpodzime merged commit 0130d34 into storaged-project:master Jun 19, 2025
42 of 46 checks passed
@thesamesam thesamesam deleted the bashism branch June 19, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants