Add a unique device identifier #1182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently device name is commonly used as a unique device identifier both in blivet internally and in Anaconda. The problem with this is that duplicate names are allowed in the system in some cases -- btrfs names doesn't need to be unique and we can also have two different devices with the same name if they use different technologies (e.g. an LVM VG and MD array can share the same name). The new "device_ID" parameter is designed to be usable as a unique identifier and to be different for devices that share the same name. The device ID looks as follows: - name for disks, partitions and loop devices - LVM-<name> for LVM VGs and LVs - BTRFS-<uuid>-<name> for btrfs volumes and subvolumes - STRATIS-<name> for Stratis devices - LUKS-<name> for LUKS mapped devices - MDRAID-<name> for MD arrays - DM-<name> for generic DM devices
We can now internally use the device_id instead of name when getting device to be sure we will get the expected device a not a different device with the same name.
|
Jenkins, test this please. |
vojtechtrefny
force-pushed
the
3.9-devel_unique-device-id
branch
from
3360d4a to
3e23729
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
device_ididentifier is meant to be unique even for devices with the same name. The primary user for this will be Anaconda which needs an ID that will be a unique string stable betweenreset()calls.The device ID looks as follows:
namefor disks, partitions and loop devicesLVM-<name>for LVM VGs and LVsBTRFS-<uuid>-<name>for btrfs volumes and subvolumesSTRATIS-<name>for Stratis devicesLUKS-<name>for LUKS mapped devicesMDRAID-<name>for MD arraysDM-<name>for generic DM devicesBtrfs is currently the only device type that allows duplicate names for volumes so UUID is used for btrfs volumes. For other devices (LVM, MD...) the device name must be unique so we can use the name with technology prefix.