fix(tianmu): fix up the problem of adding 2 to the user-defined variable each time and fix up a crash when executing multiple nested queries with user-defined variable (#1897)(#1913) #1935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ble each time
and fix up a crash when executing multiple nested queries with user-defined variable (stoneatom#1897)(stoneatom#1913)
cause: multiple executions due to logical structure flaws
solution: add necessary condition judgment statements
PR Close stoneatom#1897 stoneatom#1913
|
Thanks for the contribution! Please review the labels and make any necessary changes. |
|
100% new code coverage |
|
issue1662 has wrong result. I have corrected the result under new code, which is same as innodb engine |
|
|
haitaoguan
approved these changes
Jul 11, 2023
RingsC
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary about this PR
Issue Number: close #1897 #1913 #1910
Tests Check List
Changelog
Documentation