Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tianmu): bugfix expression-column base on user value update by row order #1903 #1928

Merged
merged 1 commit into from
Jul 5, 2023
Merged

fix(tianmu): bugfix expression-column base on user value update by row order #1903 #1928

merged 1 commit into from
Jul 5, 2023

Conversation

Double0101
Copy link
Collaborator

Cause:
Materialize in temptable fill buffer by column order.The user value
base on previous column cannot get the true value. Solution:
Column base on user value fill buffer by row order.

Summary about this PR

Issue Number: close #1903

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Jul 5, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-bug bug for pull request label Jul 5, 2023
@Double0101 Double0101 force-pushed the userval-rowoder branch 2 times, most recently from 20e13dc to 74afa03 Compare July 5, 2023 02:51
@Double0101 Double0101 self-assigned this Jul 5, 2023
@Double0101
Copy link
Collaborator Author 

--------------------------------------------------------------------------
The servers were restarted 22 times
Spent 1867.295 of 1245 seconds executing testcases

Completed: All 276 tests were successful.

@Double0101
fix(tianmu): bugfix expression-column base on user value update by ro…
70d84b7 
…w order stoneatom#1903

Cause:
  Materialize in temptable fill buffer by column order.The user value
base on previous column cannot get the true value.
Solution:
  Column base on user value fill buffer by row order.
@RingsC RingsC merged commit 7321c63 into stoneatom:stonedb-5.7-dev Jul 5, 2023
@Double0101 Double0101 deleted the userval-rowoder branch July 19, 2023 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haitaoguan haitaoguan haitaoguan approved these changes

@RingsC RingsC RingsC approved these changes

@zhongshengstoneatom zhongshengstoneatom Awaiting requested review from zhongshengstoneatom

Assignees

@Double0101 Double0101

Labels
PR-bug bug for pull request
Projects
None yet
Milestone
No milestone
3 participants
@Double0101 @RingsC @haitaoguan