Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNF-16437: Enhance templates to pass through CPU architecture information #178

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

CNF-16437: Enhance templates to pass through CPU architecture information #178

wants to merge 1 commit into from

Conversation

fontivan
Copy link

  • For Assisted Installer templates:
    • There are now three InfraEnv objects created:
      1. The original one without any architecture specified
      2. A new x86_64 specific one
      3. A new aarch64 specific one
    • The BareMetalHost template will select an architecture specific InfraEnv if CPUArchitecture was defined, or else will use the original non-specific one
    • The BareMetalHost template will also explicitly include the CPUArchitecture in its spec if it was defined
  • For Image Based Installer teampltes:
    • The BareMetalHost template will explicitly include the CPUArchitecture in its spec if it was defined

@fontivan
CNF-16437: Enhance templates to pass through CPU architecture informa…
32ee8d0 
…tion

- For Assisted Installer templates:
	* There are now three InfraEnv objects created:
		1. The original one without any architecture specified
		2. A new x86_64 specific one
		3. A new aarch64 specific one
	* The BareMetalHost template will select an architecture specific InfraEnv if CPUArchitecture was defined, or else will use the original non-specific one
	* The BareMetalHost template will also explicitly include the CPUArchitecture in its spec if it was defined
- For Image Based Installer teampltes:
	* The BareMetalHost template will explicitly include the CPUArchitecture in its spec if it was defined

Signed-off-by: Steven Skeard <[email protected]>
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fontivan
Once this PR has been reviewed and has the lgtm label, please assign carbonin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 17, 2025

Hi @fontivan. Thanks for your PR.

I'm waiting for a stolostron member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@fontivan
Copy link
Author

/hold WIP - Requires IBI testing and ARM testing

@fontivan
Copy link
Author

x86 assisted installer and image based installer tests were both successful
arm tests to follow once I obtain access to hardware

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dco-signoff: yes do-not-merge/hold do-not-merge/work-in-progress needs-ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fontivan