Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACM-14578: Adding supported TLS ciphers #178

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

moadz
Copy link

@moadz moadz commented Oct 10, 2024

@@ -25,6 +25,7 @@ local defaults = {
tls: {},
rateLimiter: {},
internal: {},
securityContext: {},
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jacobbaungard my update introduces this change (stolostron/observatorium#79) is this going to be a problem?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, good question. I don't believe it would be a problem.

We do have this in the running obs-api container

          securityContext:
            privileged: false
            readOnlyRootFilesystem: true

It is added in the operator here:

As far as I understand we add those settings on top of any set by the securityContext here. Might be worth to just double check that the deployment though when testing this change.

Copy link

@moadz
Copy link
Author

moadz commented Oct 10, 2024

/hold

Copy link

@jacobbaungard jacobbaungard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Oct 10, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jacobbaungard, moadz
Once this PR has been reviewed and has the lgtm label, please assign saswatamcode for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@moadz
Copy link
Author

moadz commented Oct 11, 2024

/retest

@moadz
Copy link
Author

moadz commented Oct 11, 2024

/test e2e-kind

1 similar comment
@moadz
Copy link
Author

moadz commented Oct 14, 2024

/test e2e-kind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants