-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACM-14578: Adding supported TLS ciphers #178
base: main
Are you sure you want to change the base?
Conversation
@@ -25,6 +25,7 @@ local defaults = { | |||
tls: {}, | |||
rateLimiter: {}, | |||
internal: {}, | |||
securityContext: {}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jacobbaungard my update introduces this change (stolostron/observatorium#79) is this going to be a problem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, good question. I don't believe it would be a problem.
We do have this in the running obs-api container
securityContext:
privileged: false
readOnlyRootFilesystem: true
It is added in the operator here:
template+: { |
As far as I understand we add those settings on top of any set by the securityContext
here. Might be worth to just double check that the deployment though when testing this change.
Quality Gate passedIssues Measures |
/hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jacobbaungard, moadz The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/test e2e-kind |
1 similar comment
/test e2e-kind |
Addresses https://issues.redhat.com/browse/ACM-14578