Update AcmDropdown to use PatternFly v5 Menu Components - Policy Bulk actions menu #4316
Conversation
Signed-off-by: vsanghishetty <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vishsanghishetty The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: vsanghishetty <[email protected]>
Signed-off-by: vsanghishetty <[email protected]>
vishsanghishetty
changed the title
vishsanghishetty
changed the title
Signed-off-by: vsanghishetty <[email protected]>
Signed-off-by: vsanghishetty <[email protected]>
- Reduce type repetition - Disable items that will do nothing - Restore deleted comments - Remove 'dropdown-action' type which was unused and almost indistinguishable from 'bulk-action' - Move subactions to 'action-group' instead of adding flyoutMenu to 'bulk-action' - Fix separators on AcmDropdown - Simplify conversion for TableActionsDropdown to AcmDropdown Signed-off-by: Kevin Cormier <[email protected]>
Signed-off-by: Kevin Cormier <[email protected]>
Flyout menu fixes
|
@vishsanghishetty: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
Migrate to PatternFly v5 Menu Components - This PR is for ticket
This PR updates our dropdown components to use PatternFly v5's new menu system, replacing the deprecated dropdown components. The changes include support for nested menus (flyout) and proper separator handling.
What's Changed
MenuMenuToggleandPoppercomponentsPolicyActionDropdownPoliciesPage, bulk actions menu in the toolbar