Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add container-diff #218

Merged
merged 16 commits into from
Feb 19, 2025
Merged

refactor: add container-diff #218

merged 16 commits into from
Feb 19, 2025

Conversation

adthrasher
Copy link
Member

@adthrasher adthrasher commented Feb 13, 2025

Update the digest check for container differences. Since adding the digest check, we've encountered issues and false positives. container-diff provides a deeper (hopefully more robust) check.

This also adds a step to the CI to update containers to point to the branch images for pytest.
It makes developer_scripts/update_container_tags.sh more robust.
It also fixes a small bug in the methylation process_raw_idats script.

Before submitting this PR, please make sure:

  • You have added a few sentences describing the PR here.
  • You have added yourself or the appropriate individual as the assignee.
  • You have added at least one relevant code reviewer to the PR.
  • The code passes all CI tests without any errors or warnings.
  • You have added tests (when appropriate).
  • You have added an entry in any relevant CHANGELOGs (when appropriate).
  • If you have made any changes to the scripts/ or docker/ directories, please ensure any image versions have been incremented accordingly!
  • You have updated the README or other documentation to account for these changes (when appropriate).

@adthrasher adthrasher self-assigned this Feb 13, 2025
@adthrasher adthrasher requested a review from a-frantz February 17, 2025 14:34
@adthrasher adthrasher marked this pull request as ready for review February 17, 2025 14:34
@a-frantz
Copy link
Member

The new check is failing for the minfi image. Any idea why that it is? I don't see any changes to it in the "files changed" tab.

@adthrasher
Copy link
Member Author

The new check is failing for the minfi image. Any idea why that it is? I don't see any changes to it in the "files changed" tab.

Yeah, it's correct. This commit (5af65ae#diff-65053fa5a6e57a96b08ea68284f14b607cf161e2efbcfb602ef6f74c97af0c2b) reformatted the R script, but didn't bump the container revision. I'm not convinced that a reformat needs a revision bump, but the check correctly finds that change.

Copy link
Member

@a-frantz a-frantz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oop sorry. You need to update the STAR and minfi container values

@a-frantz
Copy link
Member

@adthrasher I think that with the CI changes, we should have green CI now. IDK why the methylation pytest is failing. But aside from that these changes look good.

@adthrasher
Copy link
Member Author

@adthrasher I think that with the CI changes, we should have green CI now. IDK why the methylation pytest is failing. But aside from that these changes look good.

In typical R fashion, the error message is unhelpful.

Error in h(simpleError(msg, call)) : 
  error in evaluating the argument 'x' in selecting a method for function 'colnames': object 'CN' not found
Calls: colnames -> .handleSimpleError -> h
Execution halted

@adthrasher adthrasher linked an issue Feb 19, 2025 that may be closed by this pull request
@adthrasher adthrasher requested a review from a-frantz February 19, 2025 16:19
@adthrasher adthrasher merged commit 8214573 into main Feb 19, 2025
45 checks passed
@adthrasher adthrasher deleted the fix/docker_digest branch February 19, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bumping a docker image necessitates failing CI before merge
2 participants