-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add container-diff #218
Conversation
The new check is failing for the |
Yeah, it's correct. This commit (5af65ae#diff-65053fa5a6e57a96b08ea68284f14b607cf161e2efbcfb602ef6f74c97af0c2b) reformatted the R script, but didn't bump the container revision. I'm not convinced that a reformat needs a revision bump, but the check correctly finds that change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oop sorry. You need to update the STAR and minfi
container values
@adthrasher I think that with the CI changes, we should have green CI now. IDK why the |
In typical R fashion, the error message is unhelpful.
|
Update the digest check for container differences. Since adding the digest check, we've encountered issues and false positives.
container-diff
provides a deeper (hopefully more robust) check.This also adds a step to the CI to update containers to point to the branch images for
pytest
.It makes
developer_scripts/update_container_tags.sh
more robust.It also fixes a small bug in the methylation
process_raw_idats
script.Before submitting this PR, please make sure:
scripts/
ordocker/
directories, please ensure any image versions have been incremented accordingly!