Added new parameters to quota.set workflow #329
+193
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added new compute quota fields to the quota.set action
Added the new quotas to the quota_actions.py
Updated quota_details.py with new parameters. Adjusted quota_action.py to limit line length of quota details.
Added parameters to openstack_quoata.py. WIP: looking to see if better implementation for this through the api
Adjusted call to set the quotas to allow to pass all to be set in one call. Updated tests to reflect the new call.
Added set quota call for network and volume. Docs i saw seemed to suggest some of the quotas were classed under compute but appears not. Updated tests to reflect changes.
Loop quotas and remove any keys with 0 value as these are marked as no change. Only make call to set relevant quota if they have values to change. Removed dataclasses import as no longer used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added new compute parameters to the quota.set workflow.
Changed method calls to pass the quotas as a dictionary instead of individual lines.
Updated the unit tests to reflect the changes.
Added start of quota.show methods for review.
Submitter:
Have you (where applicable):
Reviewer
Does this PR:
libdirectory?liblayers?