Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump dev charts to staging #273

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

bump dev charts to staging #273

wants to merge 3 commits into from

Conversation

anish-mudaraddi
Copy link
Collaborator

  • add opensearch chart to staging
  • bump cert-manager to 1.15.3
  • fix inconsistency with chatops values - env needs to be a cluster-specific value

This PR does not affect infrastructure charts like capi/capi-addons. See PR #272

- add opensearch chart to staging
- bump cert-manager to 1.15.3
- fix inconsistency with chatops values - `env` needs to be a cluster-specific value

This PR does not affect infrastructure charts like capi/capi-addons. See PR #272
@@ -1,4 +1,4 @@
env: staging
env: dev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this needs to be set back to staging

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this a cluster-specific value I override the value here - clusters/staging/worker/chatops-values.yaml
This means that staging/chatops/values.yaml matches exactly with dev/chatops/values.yaml enabling promotion workflow to be a simple copy-paste

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change to this something like NotSet and add something to the helm chart to error with something like

env is 'NotSet', please specify this using the override param

Since this is something I can see other people getting confused by

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leave it for another PR - @khalford should look at this

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what the solution is for this PR but this is the current status.
ChatOps is going to stay on staging for now and not be promoted to production. This is because I willl be moving ChatOps off of ArgoCD onto a different deployment

@DavidFair
Copy link
Collaborator

(some review comments might need to be backported to dev, if you throw them into this PR we can do both at the same time)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants