Update demo for Three.js r95 #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stewdio have you had a chance to try this update? |
|
A reply would be nice if you expect people to contribute to your repository. |
|
@paulmasson is your demo still live? I might be able to have a go at testing this with some 6DOF gear + faff about with the standing matrix a little. In any case I see your diff - going to give it a go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there have been a great many changes to how Three.js handles WebVR since r87, I thought it would be simpler to jump over past issues, like #10, and go directly to the newest version. This PR updates the demo to use current methods. Live link here for testing:
https://rawgit.com/paulmasson/THREE.VRController/patch-3/
I can verify that it functions as expected for Oculus Go, but only with the standing matrix not set. I do not have other equipment for testing, so someone else needs to do that. I would assume past issues have been addressed for 6DOF equipment.