Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full infrastructure upgrade so g11n is ready to roll #38

Closed
wants to merge 6 commits into from

Conversation

tdd
Copy link
Collaborator

@tdd tdd commented Feb 18, 2015

Hey Steve!

First off, thanks a ton for this amazing workshop, one of the most didactic ones. Love it! ❤️

As part of the nodeschool/organizers#64 effort, I'm in the process of bringing all workshopper-based workshops up to snuff on their infrastructure (workshopper, workshopper-exercise and, when applicable, workshopper-boilerplate), and then adding the FR L10n across the board.

You can see this work done in the most-translated workshop so far, the beloved learnyounode. It's undergoing PR review for planetproto and expressworks, and others are being upgraded as we speak.

I'm PR'ing that work in two phases for all module owners:

  1. Infrastructure upgrade so your stuff is ready for L10n. These are infra-upgrade branches, with a various amount of commits, depending on other issues.
    • (For instance, in your case I also stripped obsolete / ill-named / redundant subdirs (tests/), renamed the binary entry point to prevent confusion, and migrated problem texts to more-advanced formatting using Markdown.)
  2. French-language L10n proper (for exercises and, if needed, solutions).

So here goes. I'd love to get your feedback on this, and generally help move this forward to completion very quickly. We're trying to have as many updated packages in npm as we can by Friday night, so NodeSchool Paris 1, which happens on Saturday, has as many French-speaking workshops as possible 😉

Oh, by the way: you have a number of "Boilerplate" sections in problem texts; would you like me to move this over to workshopper-boilerplate features (boilerplate files exist in exercise dirs, and are automagically put in the working directory and referenced in the exercise text for the user to start with), or do you prefer these to stay embedded in the problem text instead?

I'm prepping the FR L10n right now. Looking forward to your feedback on this.

Best,

tdd added 6 commits February 18, 2015 16:10
… get better formatting and follows more recent workshop practices.
…e verbose, but workshopper's API grew to enable loads more stuff…
…ormer versions of exercise solutions, now in subdirs for each exercise.
…oid confusion (not a Promise impl) and follow current workshop practices.
…eprecation. Re-verified all exercises and solutions with them.
@tdd tdd mentioned this pull request Feb 19, 2015
@TimothyGu
Copy link
Collaborator

Let's move the discussion to #40.

@TimothyGu TimothyGu closed this Apr 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants