add remove_handler, wait_for_load_page, expect_response, expect_response #40

3mora2 · 2025-01-26T04:31:41Z

add remove_handler to stop listen to event
add expect_response, expect_response as in playwright-python
add wait_for_load_page to wait until page loaded

- add remove_handler to stop listen to event - add expect_response, expect_response as in playwright-python - add wait_for_page_load to wait until page loaded

stephanlensky

Thanks for the submission! I left a few comments, let me know when you have a chance to look at them.

Overall, the RequestExpectation/ResponseExpectation is a neat idea, if we can clean it up a bit I'd be happy to accept it into the library.

One additional note: can you please autoformat and lint the code using the scripts/format.sh and scripts/lint.sh scripts? Thank you.

zendriver/core/tab.py

examples/wait_for_page.py

zendriver/core/tab.py

zendriver/core/connection.py

examples/wait_for_page.py

- fix `remove_handler` - improve `expect_*` - improve `RequestExpectation`

stephanlensky

Thanks, I left a few more comments.

Did you see my note here?

can you please autoformat and lint the code using the scripts/format.sh and scripts/lint.sh scripts? Thank you.

examples/wait_for_page.py

zendriver/core/tab.py

zendriver/core/connection.py

zendriver/core/tab.py

.gitignore

khamaileon · 2025-02-03T10:28:27Z

Hey guys, I'm following this pull request closely because it addresses two issues I've already encountered. However, I think it could use a bit more documentation and, most importantly, some unit tests. What do you think? Let me know if I can help as well.

stephanlensky · 2025-02-03T13:57:47Z

Agreed, happy to take some help here, I won't have time to do either of those things anytime soon. I'll leave it to you to coordinate though.

BTW, sorry for the delay in the final review, I'll try to get to it tonight.

khamaileon · 2025-02-05T11:20:59Z

Hi @3mora2, I moved remove_handler to a separate pull request. I made some changes and added a few tests. Feel free to take a look and share your feedback!

stephanlensky · 2025-02-06T04:10:15Z

Hey @3mora2, as @khamaileon mentioned, I just merged another PR to add remove_handler here: #50

You'll want to merge latest master to get the change.

Otherwise, after we switch to using regular expressions and get the change added to CHANGELOG.md I'll be happy to merge this and release a new version for you.

khamaileon · 2025-02-06T11:16:36Z

zendriver/core/connection.py

Hi @3mora2 Thank you for spotting this. I believe this should never have gone this far, and it's better to alert the user of their mistake. Here’s a suggestion: #52

Hey @khamaileon, Ok

stephanlensky · 2025-02-06T16:38:14Z

I just merged #52 and fixed the conflict in this PR. Almost ready to merge, but looks like there is a lint issue with the expectation classes (see here).

Maybe we can fix this by having both of them derive from an abstract base class?

I'll try to take a look at fixing it tonight if you don't get to it first.

BTW, do you want credit for the change? You can add it in the CHANGELOG.md.

If you want, you can also update the line in CHANELOG.md for tab.remove_handlers to add your name since you worked on it together with @khamaileon.

3mora2 · 2025-02-06T16:59:47Z

check it

khamaileon · 2025-02-06T19:06:16Z

~~@stephanlensky be careful, in CHANGELOG you talked about wait_for_page_load instead of wait_for_ready_state.~~

Sorry, I misread; it was the commit change message.

…nse (#40) * add remove_handler, wait_for_load_page, - add remove_handler to stop listen to event - add expect_response, expect_response as in playwright-python - add wait_for_page_load to wait until page loaded * improve - fix `remove_handler` - improve `expect_*` - improve `RequestExpectation` * improve and format * Update .gitignore * change to re.fullmatch * Update connection.py * Update tab.py * Update CHANGELOG.md * Update CHANGELOG.md --------- Co-authored-by: Stephan Lensky <[email protected]>

add remove_handler, wait_for_load_page,

952aac0

- add remove_handler to stop listen to event - add expect_response, expect_response as in playwright-python - add wait_for_page_load to wait until page loaded

stephanlensky requested changes Jan 28, 2025

View reviewed changes

3mora2 and others added 2 commits January 29, 2025 00:25

Merge branch 'stephanlensky:main' into main

93b9bf9

improve

d176c7c

- fix `remove_handler` - improve `expect_*` - improve `RequestExpectation`

3mora2 requested a review from stephanlensky January 29, 2025 00:34

Merge branch 'main' into main

d976403

stephanlensky requested changes Feb 2, 2025

View reviewed changes

stephanlensky reviewed Feb 2, 2025

View reviewed changes

.gitignore Outdated Show resolved Hide resolved

3mora2 added 2 commits February 3, 2025 05:01

improve and format

09e8426

Merge branch 'main' of https://github.com/3mora2/zendriver

9339d6a

3mora2 requested a review from stephanlensky February 3, 2025 03:04

Update .gitignore

eac31c1

3mora2 and others added 2 commits February 6, 2025 08:23

Merge branch 'stephanlensky:main' into main

ee27561

change to re.fullmatch

fcd87c8

khamaileon reviewed Feb 6, 2025

View reviewed changes

3mora2 and others added 2 commits February 6, 2025 16:08

Update connection.py

0b25053

Merge branch 'main' into main

87dd8da

stephanlensky and others added 3 commits February 6, 2025 11:40

Merge branch 'main' into main

3772f00

Update tab.py

0c626bf

Update CHANGELOG.md

49b4339

Update CHANGELOG.md

6c9a24e

stephanlensky merged commit eedfded into stephanlensky:main Feb 6, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add remove_handler, wait_for_load_page, expect_response, expect_response #40

add remove_handler, wait_for_load_page, expect_response, expect_response #40

3mora2 commented Jan 26, 2025

stephanlensky left a comment

stephanlensky left a comment

khamaileon commented Feb 3, 2025

stephanlensky commented Feb 3, 2025

khamaileon commented Feb 5, 2025

stephanlensky commented Feb 6, 2025

khamaileon Feb 6, 2025

3mora2 Feb 6, 2025

stephanlensky commented Feb 6, 2025 •

edited

Loading

3mora2 commented Feb 6, 2025

khamaileon commented Feb 6, 2025 •

edited

Loading

add remove_handler, wait_for_load_page, expect_response, expect_response #40

add remove_handler, wait_for_load_page, expect_response, expect_response #40

Conversation

3mora2 commented Jan 26, 2025

stephanlensky left a comment

Choose a reason for hiding this comment

stephanlensky left a comment

Choose a reason for hiding this comment

khamaileon commented Feb 3, 2025

stephanlensky commented Feb 3, 2025

khamaileon commented Feb 5, 2025

stephanlensky commented Feb 6, 2025

khamaileon Feb 6, 2025

Choose a reason for hiding this comment

3mora2 Feb 6, 2025

Choose a reason for hiding this comment

stephanlensky commented Feb 6, 2025 • edited Loading

3mora2 commented Feb 6, 2025

khamaileon commented Feb 6, 2025 • edited Loading

stephanlensky commented Feb 6, 2025 •

edited

Loading

khamaileon commented Feb 6, 2025 •

edited

Loading