Skip to content

Move Sora details into a note on CLI page #1273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

leighmcculloch
Copy link
Member

What

Move the Sora details into a note block on the CLI documentation page rather than being a section.

Why

It's somewhat confusing going to the page and seeing Sora listed under CLI. It makes it sound like the Sora tool is another CLI, when it's a GUI ontop of the CLI. A note looks to me like a good way to present that information. The page is primarily about the Stellar CLI, and notes are a good way to present ancillary information that take the user away to other related things.

@leighmcculloch leighmcculloch marked this pull request as ready for review February 11, 2025 10:54
@stellar-jenkins
Copy link

1 similar comment
@stellar-jenkins
Copy link

Copy link
Contributor

@briwylde08 briwylde08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sora is a third party tool, correct? That also might be worth mentioning in the note.

@leighmcculloch leighmcculloch merged commit b9337e8 into main Feb 11, 2025
2 checks passed
@leighmcculloch leighmcculloch deleted the change-sora-info-to-be-a-note-on-cli-page branch February 11, 2025 17:42
@leighmcculloch
Copy link
Member Author

leighmcculloch commented Feb 11, 2025

That also might be worth mentioning in the note.

Oops, I merged this before fixing this. I'll open a change modifying it.

@briwylde08 What's the best way to present this in the docs? In general other pages of the docs don't really distinguish between SDF maintained and third party maintained projects.

@briwylde08
Copy link
Contributor

We don't really do that in the docs at this point, but I think it's probably worth mentioning. We have an issue open where the DevRel team will go through all the various tools listed in the docs to ensure they're being maintained (see it here: #1191). And we can add into the flow to also indicate whether the tool is SDF-maintained or a third party tool. I also think it might be a good idea to have a general disclaimer on the Tools page that says like... "SDF is not responsible for third-party tools not working" but I can work with Wela on some language there.

What do you think?

@briwylde08
Copy link
Contributor

@leighmcculloch that was a long-winded answer but in this particular case I would just add a little language, which I did here: #1275

@leighmcculloch
Copy link
Member Author

Approved the PR, thanks, and 👍🏻 some language or way to signal products are external would be helpful and improve how projects are framed in general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants