pin Xcode version to 15.1 & modify xcodeWrapper #19822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (29)
|
siddarthkay
force-pushed
the
fix-xcode-wrapper
branch
3 times, most recently
from
c7274a1
to
47b722a
Compare
jakubgs
approved these changes
May 6, 2024
siddarthkay
commented
May 6, 2024
siddarthkay
commented
May 6, 2024
siddarthkay
force-pushed
the
fix-xcode-wrapper
branch
3 times, most recently
from
682e466
to
fa4ac8a
Compare
|
@jakubgs : I requested re-review, this PR has changed a lot from your last review. |
siddarthkay
force-pushed
the
fix-xcode-wrapper
branch
from
fa4ac8a
to
561a0da
Compare
siddarthkay
changed the title
siddarthkay
force-pushed
the
fix-xcode-wrapper
branch
3 times, most recently
from
753433c
to
662efd0
Compare
siddarthkay
force-pushed
the
fix-xcode-wrapper
branch
2 times, most recently
from
640894d
to
0f28da2
Compare
fixes #19770 Devs are often unaware of the supported Xcode version and often run into weird build issues with either higher or lower Xcode versions. This change ensures we convey that change when devs execute `make run-ios` This commit also attempts to ensure `xcodebuild` command is wrapped with `XcodeWrapper`. - iOS - macOS status: ready
siddarthkay
force-pushed
the
fix-xcode-wrapper
branch
from
0f28da2
to
18b19c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #19770
Summary
Devs are often unaware of the supported Xcode version and often run into weird build issues with either higher or lower Xcode versions.
We currently only support Xcode 15.1
This change ensures we convey that change when devs execute
make run-iosThis PR also attempts to ensure
xcodebuildcommand is wrapped withXcodeWrapper.Platforms
status: ready