Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collectible spinner always shown for users without collectibles #19757 #19808

Merged
merged 3 commits into from Apr 29, 2024
Merged

Collectible spinner always shown for users without collectibles #19757 #19808

merged 3 commits into from Apr 29, 2024

Conversation

mmilad75
Copy link
Contributor

fixes #19757

Summary

Screenshot 2024-04-25 at 20 57 01

@mmilad75 mmilad75 self-assigned this Apr 25, 2024
@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA Apr 25, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Apr 25, 2024 •
edited

Jenkins Builds

Click to see older builds (4)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 77fae86 #1 2024-04-25 17:33:10 ~4 min tests 📄log
✔️ 77fae86 #1 2024-04-25 17:36:58 ~8 min android-e2e 🤖apk 📲
✔️ 77fae86 #1 2024-04-25 17:37:02 ~8 min ios 📱ipa 📲
✔️ 77fae86 #1 2024-04-25 17:37:06 ~8 min android 🤖apk 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 8d60e4a #2 2024-04-26 10:45:42 ~4 min tests 📄log
✔️ 8d60e4a #2 2024-04-26 10:49:25 ~8 min android-e2e 🤖apk 📲
✔️ 8d60e4a #2 2024-04-26 10:49:31 ~8 min android 🤖apk 📲
✔️ 8d60e4a #2 2024-04-26 10:49:31 ~8 min ios 📱ipa 📲
❌ 9220c15 #3 2024-04-29 11:41:50 ~4 min tests 📄log
✔️ 9220c15 #3 2024-04-29 11:45:45 ~8 min android-e2e 🤖apk 📲
✔️ 9220c15 #3 2024-04-29 11:45:50 ~8 min android 🤖apk 📲
✔️ 9220c15 #3 2024-04-29 11:45:51 ~8 min ios 📱ipa 📲
✔️ 9220c15 #4 2024-04-29 12:20:31 ~2 min tests 📄log

@ibrkhalil ibrkhalil moved this from REVIEW to E2E Tests in Pipeline for QA Apr 27, 2024
@status-im-auto
Copy link
Member

92% of end-end tests have passed

Total executed tests: 52
Failed tests: 2
Expected to fail tests: 2
Passed tests: 48

IDs of failed tests: 727230,727229 

IDs of expected to fail tests: 703495,703503

Failed tests (2)

Click to expand
  • Rerun failed tests

    • Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230

    Device 2: Find `Text` by `xpath`: `//android.view.ViewGroup[@content-desc='container']/android.widget.TextView[@text='Ether']/../android.widget.TextView[3]`
    Device 2: `Text` is `0.0291 ETH` 

    critical/test_wallet.py:127: in test_wallet_send_asset_from_drawer
    self._check_balances_after_tx(amount_to_send, sender_balance, receiver_balance, eth_amount_sender,
critical/test_wallet.py:98: in _check_balances_after_tx
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Eth amount in the senders wallet is 0.0439 but should be 0.0438
E    Eth amount in the receivers wallet is 0.0291 but should be 0.0292



    2. test_wallet_send_eth, id: 727229

    Device 1: Text is 0.04388 ETH
    Device 2: Text is 0.0291 ETH 

    critical/test_wallet.py:112: in test_wallet_send_eth
    self._check_balances_after_tx(amount_to_send, sender_balance, receiver_balance, eth_amount_sender,
critical/test_wallet.py:98: in _check_balances_after_tx
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Eth amount in the senders wallet is 0.0439 but should be 0.0438
E    Eth amount in the receivers wallet is 0.0291 but should be 0.0292



    Expected to fail tests (2)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495

    # STEP: Change device time so chat will be unmuted by timer
    Device 2: Long press on ChatElement 

    critical/chats/test_group_chat.py:464: in test_group_chat_mute_chat
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Chat is still muted after timeout

    [[Chat is not unmuted after expected time: https://github.com//issues/19627]]

    Device sessions

    Passed tests (48)

    Click to expand

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_leave, id: 702845
    Device sessions

    5. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    Device sessions

    2. test_wallet_add_remove_watch_only_account, id: 727232
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_deep_links, id: 702775
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    3. test_group_chat_reactions, id: 703202
    Device sessions

    4. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    5. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    10. test_community_message_edit, id: 702843
    Device sessions

    11. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    @VolodLytvynenko VolodLytvynenko self-assigned this Apr 29, 2024
    @VolodLytvynenko VolodLytvynenko moved this from E2E Tests to IN TESTING in Pipeline for QA Apr 29, 2024
    @VolodLytvynenko
    Copy link
    Contributor

    Hi @mmilad75 thank you for fixes. PR is checked and ready to be merged

    @VolodLytvynenko VolodLytvynenko moved this from IN TESTING to MERGE in Pipeline for QA Apr 29, 2024
    @mmilad75 mmilad75 merged commit bd192b0 into develop Apr 29, 2024
    6 checks passed
    Pipeline for QA automation moved this from MERGE to DONE Apr 29, 2024
    @mmilad75 mmilad75 deleted the milad/19757-fix-image-loading-collectible-tab branch April 29, 2024 12:35
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @shivekkhurana shivekkhurana shivekkhurana approved these changes

    @J-Son89 J-Son89 J-Son89 approved these changes

    @ulisesmac ulisesmac Awaiting requested review from ulisesmac

    @vkjr vkjr Awaiting requested review from vkjr

    @briansztamfater briansztamfater Awaiting requested review from briansztamfater

    Assignees

    @VolodLytvynenko VolodLytvynenko

    @mmilad75 mmilad75

    Labels
    request-manual-qa Tested - OK
    Projects
    Pipeline for QA
      
    DONE
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Collectible spinner always shown if no available collectibles
    7 participants
    @mmilad75 @status-im-auto @VolodLytvynenko @shivekkhurana @vkjr @J-Son89 @ibrkhalil