Collectible header #19783
Merged
Collectible header #19783
+247
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (59)
|
ajayesivan
force-pushed
the
18595-collectible-header
branch
2 times, most recently
from
e10af72
to
16b10e5
Compare
ajayesivan
requested review from
briansztamfater,
clauxx,
J-Son89,
mmilad75 and
ulisesmac
ajayesivan
force-pushed
the
18595-collectible-header
branch
2 times, most recently
from
65a46c2
to
4f842fc
Compare
ibrkhalil
reviewed
Apr 25, 2024
ajayesivan
force-pushed
the
18595-collectible-header
branch
from
67509b4
to
35b2486
Compare
ibrkhalil
requested changes
Apr 27, 2024
Comment on lines
183
to
187
| ;; We need to delay the measurement because the navigation has an | ||
| ;; animation | ||
| (js/setTimeout #(when @title-ref | ||
| (.measureInWindow @title-ref set-title-bottom)) | ||
| 300))}]] |
There was a problem hiding this comment.
Can this delay be done using the withDelay function of reanimated in the .js file?
There was a problem hiding this comment.
but this is not an animation. The timeout is here to make sure measureInWindow is called later in time
FFFra
reviewed
May 7, 2024
ulisesmac
force-pushed
the
18595-collectible-header
branch
from
83e5b19
to
4c2e9e4
Compare
|
@FFFra I tried your code style suggestions but they are being changed by |
Co-authored-by: Ajay Sivan <[email protected]>
ulisesmac
force-pushed
the
18595-collectible-header
branch
from
8f79a3f
to
3a27fda
Compare
|
@clauxx @FFFra @ibrkhalil I already solved the problems, could you please check it again? cc: @ajayesivan |
|
@ulisesmac don't we need QA or design review for this PR? |
ulisesmac
added a commit
that referenced
this pull request
May 14, 2024
This reverts commit 5a6a0f7.
ulisesmac
added a commit
that referenced
this pull request
May 14, 2024
Comment on lines
+248
to
+249
| [reanimated/scroll-view | ||
| {:style (style/scroll-view top) |
There was a problem hiding this comment.
hi, why this is reanimated view instead of simple view?
Comment on lines
+20
to
+23
| return useAnimatedStyle(() => ({ | ||
| flex: 1, | ||
| justifyContent: 'flex-end', | ||
| backgroundColor: interpolateColor(sharedValue.value, [0, 60], [from, to], 'RGB'), |
There was a problem hiding this comment.
This approach has few drawbacks.
- I am not sure if situation is changed, but changes in js code were not visible until app restarted
- Also for consistency we should stick to a single approach. If we use this approach everywhere we will have three files, view, simple style, and animated style, for all animations and we have several animations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #18595
Summary
Improve collectible header animation.
Platforms
Areas that maybe impacted
Steps to test
Known issues
(We will handle the above issues separately)
Screenshots
Android
Light Mode:
Android.-.Light.mov
Dark Mode:
Android.-.Dark.mov
iOS
Light Mode:
iOS.-.Light.mp4
Dark Mode:
iOS.-.Dark.mp4
status: ready