Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a menu of operations for a saved address and add share and show QR code for a saved address #19782

Closed
wants to merge 3 commits into from

Conversation

ibrkhalil
Copy link
Contributor

@ibrkhalil ibrkhalil commented Apr 24, 2024

If you submit PR for issue with bounty then write here Fixes #NN where NN is issue number

otherwise

fixes #19734, #19728

Summary

...

Documentation change PR (review please): https://github.com/status-im/status.im/pull/xxx

Review notes

Testing notes

Platforms

  • Android
  • iOS
  • macOS
  • Linux
  • Windows

Areas that maybe impacted

Functional
  • 1-1 chats
  • public chats
  • group chats
  • wallet / transactions
  • dapps / app browsing
  • account recovery
  • new account
  • user profile updates
  • networks
  • mailservers
  • fleet
  • bootnodes
Non-functional
  • battery performance
  • CPU performance / speed of the app
  • network consumption

Steps to test

  • Open Status
  • ...
  • Step 3, etc.

Before and after screenshots comparison

Figma (if available) iOS (if available) Android (if available)
Please embed Image/Video here of the before and after. Please embed Image/Video here of the before and after. Please embed Image/Video here of the before and after.

status: ready

@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA Apr 24, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Apr 24, 2024

Jenkins Builds

Click to see older builds (4)
Commit #️⃣ Finished (UTC) Duration Platform Result
47d27fb #1 2024-04-24 10:29:13 ~3 min tests 📄log
✔️ 47d27fb #1 2024-04-24 10:32:26 ~7 min android 🤖apk 📲
✔️ 47d27fb #1 2024-04-24 10:33:45 ~8 min ios 📱ipa 📲
✔️ 47d27fb #1 2024-04-24 10:36:10 ~10 min android-e2e 🤖apk 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ b02a7e4 #2 2024-04-24 13:10:28 ~5 min tests 📄log
✔️ b02a7e4 #2 2024-04-24 13:10:49 ~6 min android-e2e 🤖apk 📲
✔️ b02a7e4 #2 2024-04-24 13:14:33 ~9 min ios 📱ipa 📲
✔️ b02a7e4 #2 2024-04-24 13:14:40 ~9 min android 🤖apk 📲
✔️ c80df7f #3 2024-04-24 13:36:54 ~4 min tests 📄log
✔️ c80df7f #3 2024-04-24 13:43:10 ~10 min android-e2e 🤖apk 📲
✔️ c80df7f #3 2024-04-24 13:43:16 ~10 min android 🤖apk 📲
✔️ c80df7f #3 2024-04-24 13:43:37 ~10 min ios 📱ipa 📲

@ibrkhalil ibrkhalil changed the title Show a menu of operations for a saved address Show a menu of operations for a saved address and add share saved addresses Apr 24, 2024
@ibrkhalil ibrkhalil changed the title Show a menu of operations for a saved address and add share saved addresses Show a menu of operations for a saved address and add share and show QR code for a saved address Apr 24, 2024
@ibrkhalil ibrkhalil self-assigned this Apr 24, 2024
@ibrkhalil ibrkhalil closed this May 5, 2024
Pipeline for QA automation moved this from REVIEW to DONE May 5, 2024
@ibrkhalil
Copy link
Contributor Author

Closed in favor of
#19903

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

🔳 Share QR code of a saved address
2 participants