Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reaction drawer issue #19754

Merged
merged 2 commits into from Apr 29, 2024
Merged

fix: reaction drawer issue #19754

merged 2 commits into from Apr 29, 2024

Conversation

codemaster115
Copy link
Contributor

fixes #19280

Summary

  • Reaction isn't visible [comment] in the message preview, even if the message has correctly displayed reactions in the chat
  • Bottom margin [comment] is too narrow

Platforms

  • Android
  • iOS
Functional
  • 1-1 chats
  • public chats
  • group chats

Steps to test

  • Open a chat
  • React to a message
  • Press on the React button to open the reaction drawer

Before and after screenshots comparison

Simulator Screenshot - iPhone 13 - 2024-04-22 at 07 36 50

status: ready

@codemaster115 codemaster115 self-assigned this Apr 22, 2024
@codemaster115 codemaster115 linked an issue Apr 22, 2024 that may be closed by this pull request
Posts & Attachments - Reaction drawer screen issues #19280
Closed
@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA Apr 22, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Apr 22, 2024 •
edited

Jenkins Builds

Click to see older builds (25)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 0635184 #1 2024-04-22 14:41:56 ~3 min tests 📄log
✔️ 1e637d8 #2 2024-04-22 14:47:09 ~3 min tests 📄log
✔️ 1e637d8 #2 2024-04-22 14:51:26 ~8 min android-e2e 🤖apk 📲
✔️ 1e637d8 #2 2024-04-22 14:51:36 ~8 min android 🤖apk 📲
✔️ 1e637d8 #2 2024-04-22 14:52:27 ~9 min ios 📱ipa 📲
❌ 6d09b69 #3 2024-04-22 15:14:56 ~3 min tests 📄log
✔️ 6d09b69 #3 2024-04-22 15:16:55 ~5 min android-e2e 🤖apk 📲
❌ 6d09b69 #3 2024-04-22 15:18:19 ~7 min ios 📄log
✔️ 6d09b69 #3 2024-04-22 15:20:08 ~8 min android 🤖apk 📲
✔️ fde689f #4 2024-04-22 15:53:20 ~6 min tests 📄log
✔️ fde689f #4 2024-04-22 15:53:42 ~6 min android-e2e 🤖apk 📲
✔️ fde689f #4 2024-04-22 15:55:17 ~8 min ios 📱ipa 📲
✔️ fde689f #4 2024-04-22 15:57:58 ~10 min android 🤖apk 📲
✔️ 0d2375a #5 2024-04-23 14:12:44 ~5 min tests 📄log
✔️ 0d2375a #5 2024-04-23 14:12:49 ~5 min android-e2e 🤖apk 📲
✔️ 0d2375a #5 2024-04-23 14:13:10 ~5 min android 🤖apk 📲
✔️ 0d2375a #5 2024-04-23 14:16:55 ~9 min ios 📱ipa 📲
✔️ 63f03de #6 2024-04-24 12:25:41 ~5 min android-e2e 🤖apk 📲
✔️ 63f03de #6 2024-04-24 12:25:51 ~5 min tests 📄log
✔️ 63f03de #6 2024-04-24 12:29:26 ~9 min android 🤖apk 📲
✔️ 63f03de #6 2024-04-24 12:29:37 ~9 min ios 📱ipa 📲
✔️ e284fe2 #7 2024-04-26 12:44:54 ~9 min tests 📄log
✔️ e284fe2 #7 2024-04-26 12:45:27 ~9 min ios 📱ipa 📲
✔️ e284fe2 #7 2024-04-26 12:50:15 ~14 min android-e2e 🤖apk 📲
✔️ e284fe2 #7 2024-04-26 12:51:37 ~15 min android 🤖apk 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 1217ac2 #8 2024-04-26 13:13:40 ~5 min android-e2e 🤖apk 📲
✔️ 1217ac2 #8 2024-04-26 13:13:49 ~5 min tests 📄log
✔️ 1217ac2 #8 2024-04-26 13:17:01 ~8 min ios 📱ipa 📲
✔️ 1217ac2 #8 2024-04-26 13:17:25 ~9 min android 🤖apk 📲
✔️ f76836c #9 2024-04-29 12:54:18 ~5 min tests 📄log
✔️ f76836c #9 2024-04-29 12:56:09 ~7 min android-e2e 🤖apk 📲
✔️ f76836c #9 2024-04-29 12:58:24 ~9 min ios 📱ipa 📲
✔️ f76836c #9 2024-04-29 12:58:53 ~9 min android 🤖apk 📲

@codemaster115 codemaster115 force-pushed the 19280-posts--attachments---reaction-drawer-screen-issues branch from 0635184 to 1e637d8 Compare April 22, 2024 14:42
@codemaster115 codemaster115 moved this from REVIEW to E2E Tests in Pipeline for QA Apr 22, 2024
@codemaster115 codemaster115 force-pushed the 19280-posts--attachments---reaction-drawer-screen-issues branch from 1e637d8 to 6d09b69 Compare April 22, 2024 15:10
@status-im-auto
Copy link
Member

83% of end-end tests have passed

Total executed tests: 52
Failed tests: 7
Expected to fail tests: 2
Passed tests: 43

IDs of failed tests: 727230,704613,704615,727229,702855,727232,702775 

IDs of expected to fail tests: 703495,703503

Failed tests (7)

Click to expand
  • Rerun failed tests

    • Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_edit_message, id: 702855

    Device 2: Find `Text` by `xpath`: `//*[starts-with(@text,'Message before edit 1-1')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView`
    Device 2: `Text` is `Sent` 

    critical/chats/test_1_1_public_chats.py:383: in test_1_1_chat_edit_message
    self.chat_2.chat_element_by_text(message_before_edit_1_1).wait_for_status_to_be("Delivered")
../views/chat_view.py:225: in wait_for_status_to_be
    raise TimeoutException("Message status was not changed to %s, it's %s" % (expected_status, current_status))
 Message status was not changed to Delivered, it's Sent



    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613

    Device 1: Find Button by xpath: //*[@text="open community"]
    Device 1: Tap on found: Button 

    critical/test_deep_and_universal_links.py:69: in test_links_open_universal_links_from_chat
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Community 'Status mobile QA community max' was not requested to join by the url https://status.app/c/G8EAAMR_fz8tsCQ-aR2QrCS5sVAvvzc_N3mAA-En_Zxy4JA3j7Dl1A50Pd4DbooQOMbWf7E1_4wipgDyGe8XZEappDn-Qomf9l_xyXhSYBuSQic8InCEUBSRGR0oixSTh3iw5ZCxzkGSI95Iyu1EBpcIlFOEMPHpKUBIdkkoKBJglMDKko8O8dBvBtIYncOA8mwztwLpx3C0rK_u59PldFuXe4cx#zQ3shwQnEfMtcXpHXF4qJPyCGgw2F18N3nbGzYbzsVHnMq4yK



    Device sessions

    2. test_links_deep_links, id: 702775

    Device 1: Find BrowserTab by accessibility id: browser-stack-tab
    Device 1: Tap on found: BrowserTab 

    critical/test_deep_and_universal_links.py:112: in test_links_deep_links
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Community 'Status mobile QA community max' was not requested to join by the deep link status.app://c/G8EAAMR_fz8tsCQ-aR2QrCS5sVAvvzc_N3mAA-En_Zxy4JA3j7Dl1A50Pd4DbooQOMbWf7E1_4wipgDyGe8XZEappDn-Qomf9l_xyXhSYBuSQic8InCEUBSRGR0oixSTh3iw5ZCxzkGSI95Iyu1EBpcIlFOEMPHpKUBIdkkoKBJglMDKko8O8dBvBtIYncOA8mwztwLpx3C0rK_u59PldFuXe4cx#zQ3shwQnEfMtcXpHXF4qJPyCGgw2F18N3nbGzYbzsVHnMq4yK



    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_watch_only_account, id: 727232

    Device 1: Find EditBox by accessibility id: add-address-to-watch
    Device 1: Type 0x8d2413447ff297d30bdc475f6d5cb00254685aae to EditBox 

    critical/test_wallet.py:190: in test_wallet_add_remove_watch_only_account
    self.wallet_view.add_watch_only_account(address=address_to_watch, account_name=new_account_name)
../views/wallet_view.py:115: in add_watch_only_account
    self.account_has_activity_label.wait_for_visibility_of_element()
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 1: Text by accessibility id:`account-has-activity` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_edit_delete_message_when_offline, id: 704615

    Device 1: Looking for a message by text: text after edit
    Device 1: Looking for a message by text: message to delete 

    critical/chats/test_public_chat_browsing.py:800: in test_community_edit_delete_message_when_offline
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message 'message to delete' was not deleted for the receiver



    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230

    # STEP: Getting ETH amount in the wallet of the sender before transaction
    Device 1: Find WalletTab by accessibility id: wallet-stack-tab 

    critical/test_wallet.py:117: in test_wallet_send_asset_from_drawer
    sender_balance, receiver_balance, eth_amount_sender, eth_amount_receiver = self._get_balances_before_tx()
critical/test_wallet.py:39: in _get_balances_before_tx
    self.wallet_1.wallet_tab.click()
../views/base_element.py:90: in click
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: WalletTab by accessibility id: `wallet-stack-tab` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    2. test_wallet_send_eth, id: 727229

    Device 1: Swiping right on element SlideButton
    Device 1: Find SlideButton by xpath: //*[@resource-id='slide-button-track'] 

    critical/test_wallet.py:109: in test_wallet_send_eth
    self.wallet_1.send_asset(address=self.receiver['address'], asset_name='Ether', amount=amount_to_send)
../views/wallet_view.py:93: in send_asset
    self.confirm_transaction()
../views/wallet_view.py:84: in confirm_transaction
    self.slide_and_confirm_with_password()
../views/wallet_view.py:78: in slide_and_confirm_with_password
    self.slide_button_track.slide()
../views/base_view.py:257: in slide
    self.swipe_right_on_element(width_percentage=1.3, start_x=100)
../views/base_element.py:308: in swipe_right_on_element
    location, size = self.get_element_coordinates()
../views/base_element.py:294: in get_element_coordinates
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: SlideButton by xpath: `//*[@resource-id='slide-button-track']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Expected to fail tests (2)

    Click to expand

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495

    # STEP: Change device time so chat will be unmuted by timer
    Device 2: Long press on ChatElement 

    critical/chats/test_group_chat.py:464: in test_group_chat_mute_chat
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Chat is still muted after timeout

    [[Chat is not unmuted after expected time: https://github.com//issues/19627]]

    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Passed tests (43)

    Click to expand

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    6. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    7. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_leave, id: 702845
    Device sessions

    5. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_message_delete, id: 702839
    Device sessions

    7. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    8. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    9. test_community_message_edit, id: 702843
    Device sessions

    10. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    3. test_group_chat_reactions, id: 703202
    Device sessions

    4. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    5. test_group_chat_offline_pn, id: 702808
    Device sessions

    @codemaster115 codemaster115 force-pushed the 19280-posts--attachments---reaction-drawer-screen-issues branch 2 times, most recently from fde689f to 0d2375a Compare April 23, 2024 14:06
    @status-im-auto
    Copy link
    Member

    29% of end-end tests have passed

    Total executed tests: 7
Failed tests: 2
Expected to fail tests: 3
Passed tests: 2

    IDs of failed tests: 702775,704613 

    IDs of expected to fail tests: 727230,727232,727229

    Failed tests (2)

    Click to expand
  • Rerun failed tests

    • Class TestDeepLinksOneDevice:

    1. test_links_deep_links, id: 702775

    Device 1: Find `BrowserTab` by `accessibility id`: `browser-stack-tab`
    Device 1: Tap on found: BrowserTab 

    critical/test_deep_and_universal_links.py:112: in test_links_deep_links
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Community 'e2e community token-gated' was not requested to join by the deep link status.app://c/G0IAAGRy3S0pLm1NeQ91pwKgFaFGoIlkxXmDxITXXi3KdZ7vpb9-ERczhqwoFwMK6sCPnKwA#zQ3shtJ8A3rxUZWcfWDL3vKYQBt3jMPTuf44dJUGfjZjsek66



    Device sessions

    2. test_links_open_universal_links_from_chat, id: 704613

    Device 1: Find Button by xpath: //*[@text="open community"]
    Device 1: Tap on found: Button 

    critical/test_deep_and_universal_links.py:69: in test_links_open_universal_links_from_chat
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Community 'e2e community token-gated' was not requested to join by the url https://status.app/c/G0IAAGRy3S0pLm1NeQ91pwKgFaFGoIlkxXmDxITXXi3KdZ7vpb9-ERczhqwoFwMK6sCPnKwA#zQ3shtJ8A3rxUZWcfWDL3vKYQBt3jMPTuf44dJUGfjZjsek66



    Device sessions

    Expected to fail tests (3)

    Click to expand

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Assets are not shown on Sepolia, https://github.com//issues/19752]]

    2. test_wallet_send_eth, id: 727229 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Assets are not shown on Sepolia, https://github.com//issues/19752]]

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_watch_only_account, id: 727232 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Can't find activity on Sepolia, https://github.com//issues/19752]]

    Passed tests (2)

    Click to expand

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_edit_message, id: 702855
    Device sessions

    @VolodLytvynenko VolodLytvynenko force-pushed the 19280-posts--attachments---reaction-drawer-screen-issues branch from 0d2375a to 63f03de Compare April 24, 2024 12:19
    @VolodLytvynenko VolodLytvynenko self-assigned this Apr 24, 2024
    @VolodLytvynenko VolodLytvynenko moved this from E2E Tests to IN TESTING in Pipeline for QA Apr 24, 2024
    @VolodLytvynenko
    Copy link
    Contributor

    Hi @codemaster115 thank you for PR. No issues from my side.

    @Francesca-G could you check the current PR, please?

    @VolodLytvynenko VolodLytvynenko moved this from IN TESTING to Design review in Pipeline for QA Apr 24, 2024
    Francesca-G
    Francesca-G reviewed Apr 25, 2024
    View reviewed changes
    Copy link

    @Francesca-G Francesca-G left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Here's the review

    main issues are fixed, we're just missing the add reaction button and I added a comment related to the avatar that we couldn't address during the main review since it wasn't visible 🙏

    @codemaster115 codemaster115 force-pushed the 19280-posts--attachments---reaction-drawer-screen-issues branch from 63f03de to e284fe2 Compare April 26, 2024 12:35
    @Francesca-G
    Copy link

    @codemaster115 as confirmed by Mario the add reaction button isn't needed because this bottom sheet is opened by clicking the same button in chat.
    Apologies, designs are being fixed now so you can ignore my comment here

    Thanks for spotting it ☺️

    @codemaster115
    Copy link
    Contributor Author

    @codemaster115 as confirmed by Mario the add reaction button isn't needed because this bottom sheet is opened by clicking the same button in chat. Apologies, designs are being fixed now so you can ignore my comment here

    Thanks for spotting it ☺️

    Thanks for your confirmation. @Francesca-G

    @codemaster115 codemaster115 force-pushed the 19280-posts--attachments---reaction-drawer-screen-issues branch from 1217ac2 to f76836c Compare April 29, 2024 12:48
    @Francesca-G Francesca-G moved this from Design review to MERGE in Pipeline for QA Apr 29, 2024
    @codemaster115 codemaster115 merged commit d9aa885 into develop Apr 29, 2024
    6 checks passed
    Pipeline for QA automation moved this from MERGE to DONE Apr 29, 2024
    @codemaster115 codemaster115 deleted the 19280-posts--attachments---reaction-drawer-screen-issues branch April 29, 2024 13:00
    @jo-mut jo-mut moved this from DONE to E2E Tests in Pipeline for QA May 2, 2024
    @jo-mut jo-mut moved this from E2E Tests to DONE in Pipeline for QA May 2, 2024
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @Parveshdhull Parveshdhull Parveshdhull approved these changes

    @Francesca-G Francesca-G Francesca-G approved these changes

    @cammellos cammellos Awaiting requested review from cammellos

    @ibrkhalil ibrkhalil Awaiting requested review from ibrkhalil

    Assignees

    @codemaster115 codemaster115

    @VolodLytvynenko VolodLytvynenko

    Labels
    design-review-required request-manual-qa Tested - OK
    Projects
    Pipeline for QA
      
    DONE
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Posts & Attachments - Reaction drawer screen issues
    5 participants
    @codemaster115 @status-im-auto @VolodLytvynenko @Francesca-G @Parveshdhull