Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Collectible screen design issues #19721

Merged
merged 5 commits into from May 13, 2024
Merged

fix: Collectible screen design issues #19721

merged 5 commits into from May 13, 2024

Conversation

OmarBasem
Copy link
Member

@OmarBasem OmarBasem commented Apr 19, 2024 •
edited

fixes: #19701

  • Top bar icons background
  • Account and network data item background color
  • Photo saved toast position
  • Toast icon not appearing
  • Margin of image in lightbox
Screenshot_20240402_141910_Status Screenshot_20240402_141910_Status

@OmarBasem OmarBasem self-assigned this Apr 19, 2024
@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA Apr 19, 2024
@OmarBasem OmarBasem force-pushed the wallet/collectible-design-issues branch from 95e7138 to 9b0b3d6 Compare April 19, 2024 08:08
@status-im-auto
Copy link
Member

status-im-auto commented Apr 19, 2024 •
edited

Jenkins Builds

Click to see older builds (5)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 9b0b3d6 #2 2024-04-19 08:10:59 ~2 min tests 📄log
✔️ 9b0b3d6 #2 2024-04-19 08:14:35 ~6 min android-e2e 🤖apk 📲
✔️ 9b0b3d6 #2 2024-04-19 08:15:14 ~6 min android 🤖apk 📲
✔️ 9b0b3d6 #2 2024-04-19 08:18:12 ~9 min ios 📱ipa 📲
✔️ 614e488 #3 2024-05-13 07:55:25 ~4 min tests 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 53b727d #4 2024-05-13 08:01:07 ~4 min tests 📄log
✔️ 53b727d #4 2024-05-13 08:02:34 ~5 min android-e2e 🤖apk 📲
✔️ 53b727d #4 2024-05-13 08:03:02 ~6 min android 🤖apk 📲
✔️ 53b727d #4 2024-05-13 08:05:49 ~8 min ios 📱ipa 📲
✔️ dac9736 #5 2024-05-13 08:29:50 ~3 min tests 📄log
✔️ dac9736 #5 2024-05-13 08:31:55 ~6 min android 🤖apk 📲
✔️ dac9736 #5 2024-05-13 08:32:00 ~6 min android-e2e 🤖apk 📲
✔️ dac9736 #5 2024-05-13 08:34:43 ~8 min ios 📱ipa 📲

@ibrkhalil ibrkhalil moved this from REVIEW to E2E Tests in Pipeline for QA Apr 19, 2024
@status-im-auto
Copy link
Member

90% of end-end tests have passed

Total executed tests: 52
Failed tests: 3
Expected to fail tests: 2
Passed tests: 47

IDs of failed tests: 702957,704615,702958 

IDs of expected to fail tests: 703495,703503

Failed tests (3)

Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMerged:

    1. test_community_edit_delete_message_when_offline, id: 704615

    Device 1: Looking for a message by text: text after edit
    Device 1: Looking for a message by text: message to delete 

    critical/chats/test_public_chat_browsing.py:800: in test_community_edit_delete_message_when_offline
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Updated message 'text after edit' is not delivered to the receiver



    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957

    Device 2: Find Text by xpath: //android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'https://status.app/c/')]
    Device 2: Wait for element Button for max 120s and click when it is available 

    Test setup failed: activity_center/test_activity_center.py:421: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:419: in join_community
    self.join_button.wait_and_click(120)
../views/base_element.py:100: in wait_and_click
    self.wait_for_visibility_of_element(sec)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by accessibility id:`show-request-to-join-screen-button` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958 

    Test setup failed: activity_center/test_activity_center.py:421: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:419: in join_community
    self.join_button.wait_and_click(120)
../views/base_element.py:100: in wait_and_click
    self.wait_for_visibility_of_element(sec)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by accessibility id:`show-request-to-join-screen-button` is not found on the screen after wait_for_visibility_of_element



    Expected to fail tests (2)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495

    # STEP: Change device time so chat will be unmuted by timer
    Device 2: Long press on ChatElement 

    critical/chats/test_group_chat.py:464: in test_group_chat_mute_chat
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Chat is still muted after timeout

    [[Chat is not unmuted after expected time: https://github.com//issues/19627]]

    Device sessions

    Passed tests (47)

    Click to expand

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    3. test_group_chat_reactions, id: 703202
    Device sessions

    4. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    5. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_leave, id: 702845
    Device sessions

    5. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230
    2. test_wallet_send_eth, id: 727229

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_message_delete, id: 702839
    Device sessions

    7. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    8. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    9. test_community_message_edit, id: 702843
    Device sessions

    10. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    Device sessions

    2. test_wallet_add_remove_watch_only_account, id: 727232
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_deep_links, id: 702775
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    J-Son89
    J-Son89 approved these changes Apr 19, 2024
    View reviewed changes
    Copy link
    Member

    @J-Son89 J-Son89 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    looks good! one minor detail to check in the community scroll page detail (if that component is still used there)

    @churik
    Copy link
    Member

    churik commented Apr 22, 2024

    Hello!
    The e2e results are reviewed, the failed tests are not related to the PR.
    PR can proceed to the next stage - I believe in this particular case design review will be enough.

    @churik
    Copy link
    Member

    churik commented Apr 22, 2024

    @Francesca-G please, review when you have a time! thanks.

    @churik churik moved this from E2E Tests to Design review in Pipeline for QA Apr 22, 2024
    Francesca-G
    Francesca-G reviewed Apr 23, 2024
    View reviewed changes
    Copy link

    @Francesca-G Francesca-G left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Review comments here

    I didn't add a comment about the missing Jump To button as it's already logged

    @OmarBasem OmarBasem force-pushed the wallet/collectible-design-issues branch from 9b0b3d6 to 614e488 Compare May 13, 2024 07:50
    @Francesca-G Francesca-G moved this from Design review to MERGE in Pipeline for QA May 13, 2024
    @OmarBasem OmarBasem merged commit 12515a4 into develop May 13, 2024
    6 checks passed
    Pipeline for QA automation moved this from MERGE to DONE May 13, 2024
    @OmarBasem OmarBasem deleted the wallet/collectible-design-issues branch May 13, 2024 08:40
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @J-Son89 J-Son89 J-Son89 approved these changes

    @ibrkhalil ibrkhalil ibrkhalil approved these changes

    @Francesca-G Francesca-G Francesca-G approved these changes

    @vkjr vkjr Awaiting requested review from vkjr

    @smohamedjavid smohamedjavid Awaiting requested review from smohamedjavid

    Assignees

    @OmarBasem OmarBasem

    Labels
    design-review-required skip-manual-qa
    Projects
    Pipeline for QA
      
    DONE
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Collectible page small design issues
    6 participants
    @OmarBasem @status-im-auto @churik @J-Son89 @ibrkhalil @Francesca-G