Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Posts & Attachments - Reaction drawer screen issues #19280

Closed
Francesca-G opened this issue Mar 15, 2024 · 2 comments · Fixed by #19754
Closed

Posts & Attachments - Reaction drawer screen issues #19280

Francesca-G opened this issue Mar 15, 2024 · 2 comments · Fixed by #19754
Assignees
@codemaster115
Labels
E:Mobile [Crew] Design Feedback 2.27 v2.29 https://www.notion.so/Graceful-Touches-e8a5dd804cb4485ea524ec66fc632f25
Milestone
2.29.0 Beta

Comments

@Francesca-G
Copy link

Design Feedback 2.27

[Posts & Attachments] Reaction drawer screen issues

Figma frame of the Review here

  • No pressed state [comment ] of the reaction button
  • Reaction isn't visible [comment] in the message preview, even if the message has correctly displayed reactions in the chat
  • Bottom margin [comment] is too narrow
Screenshot 2024-03-15 alle 14 03 45

Reproduction

  1. Open a chat
  2. React to a message
  3. Press on the React button to open the reaction drawer

Additional Information

  • Status version: nightly
  • Operating System: Android, iOS
  • Devices in the screenshots: iPhone 13
@Francesca-G Francesca-G added the E:Mobile [Crew] Design Feedback 2.27 v2.29 https://www.notion.so/Graceful-Touches-e8a5dd804cb4485ea524ec66fc632f25 label Mar 15, 2024
@cammellos cammellos added this to the 2.29.0 Alpha milestone Apr 3, 2024
@yqrashawn yqrashawn assigned yqrashawn and unassigned yqrashawn Apr 12, 2024
@codemaster115 codemaster115 self-assigned this Apr 22, 2024
@codemaster115
Copy link
Contributor

@Francesca-G The first item is already fixed and you can see the pressed state on reactions.

@codemaster115 codemaster115 mentioned this issue Apr 22, 2024
Merged
@codemaster115 codemaster115 linked a pull request Apr 22, 2024 that will close this issue
fix: reaction drawer issue #19754
Merged
@Francesca-G
Copy link
Author

@Francesca-G The first item is already fixed and you can see the pressed state on reactions.

Looks fixed 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codemaster115 codemaster115

Labels
E:Mobile [Crew] Design Feedback 2.27 v2.29 https://www.notion.so/Graceful-Touches-e8a5dd804cb4485ea524ec66fc632f25
Projects
🔨🪶 Graceful Touches [mobile] (UI fit and finish)
Status: Done
Milestone
2.29.0 Beta
Development

Successfully merging a pull request may close this issue.

fix: reaction drawer issue status-im/status-mobile
4 participants
@cammellos @yqrashawn @codemaster115 @Francesca-G