Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load wallet connect SDK in Storybook #14698

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

stefandunca
Copy link
Contributor

@stefandunca stefandunca commented May 10, 2024

  • Resolve loading of both js source files (app and StatusQ) as relative path

Other changes

- start Wallet Connect SDK using web engine after wallet is ready
- source WC project ID from the constants in nim
- close list when opening the `ConnectDappModal`
- remove the old POC modal instantiation
- rename ConnectDappPopup to Modal for consistency
- move specific dapps related user settings to their place in the component
- add DAppsStore to be used for dapps abstraction

Updates #14556
Also:

- mock FeatureFlags nim to silence `Global.qml` warnings

Updates: #14556
Storybook: also automate related workflows for faster iteration

Also extend the inspector utils to handle Loaders and Popups

Updates: #14607
Also rename pairing modal accordingly to make room for the proper
ConnectDAppModal.qml

Closes #14607
@status-im-auto
Copy link
Member

status-im-auto commented May 10, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ bc3faef #1 2024-05-10 13:37:04 ~6 min tests/nim 📄log
✔️ bc3faef #1 2024-05-10 13:39:17 ~8 min macos/aarch64 🍎dmg
✔️ bc3faef #1 2024-05-10 13:41:29 ~10 min macos/x86_64 🍎dmg
bc3faef #1 2024-05-10 13:47:43 ~16 min tests/ui 📄log
✔️ bc3faef #1 2024-05-10 13:52:34 ~21 min linux/x86_64 📦tgz
✔️ bc3faef #2 2024-05-10 14:08:30 ~5 min macos/aarch64 🍎dmg
✔️ bc3faef #2 2024-05-10 14:09:25 ~6 min tests/nim 📄log
✔️ bc3faef #2 2024-05-10 14:10:43 ~7 min macos/x86_64 🍎dmg
bc3faef #2 2024-05-10 14:14:02 ~10 min tests/ui 📄log
✔️ bc3faef #2 2024-05-10 14:22:29 ~19 min linux/x86_64 📦tgz
✔️ bc3faef #2 2024-05-10 14:38:07 ~34 min windows/x86_64 💿exe
✔️ bc3faef #3 2024-05-20 13:16:23 ~6 min tests/nim 📄log
✔️ bc3faef #3 2024-05-20 13:16:46 ~6 min macos/aarch64 🍎dmg
✔️ bc3faef #3 2024-05-20 13:20:40 ~10 min macos/x86_64 🍎dmg
bc3faef #3 2024-05-20 13:21:54 ~11 min tests/ui 📄log
✔️ bc3faef #3 2024-05-20 13:26:59 ~16 min linux/x86_64 📦tgz
✔️ bc3faef #3 2024-05-20 13:46:31 ~36 min windows/x86_64 💿exe

@stefandunca stefandunca changed the base branch from master to dapp_connection-14607 May 10, 2024 14:02
@stefandunca stefandunca force-pushed the dapp_connection-14607 branch 8 times, most recently from 3493085 to 7fabb60 Compare May 17, 2024 11:31
Base automatically changed from dapp_connection-14607 to master May 20, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants