Graduate stew/results -> results #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnetheduck
added a commit
to status-im/nimbus-eth2
that referenced
this pull request
Apr 26, 2023
kdeme
reviewed
Apr 26, 2023
| # * Apache v2 license (license terms in the root directory or at http://www.apache.org/licenses/LICENSE-2.0). | ||
| # at your option. This file may not be copied, modified, or distributed except according to those terms. | ||
| when defined(stewWarnResults): | ||
| # This deprecation notice will be made default in some future stew commit |
There was a problem hiding this comment.
What's the idea behind having a delayed deprecation notice?
There was a problem hiding this comment.
less warnings for everyone that has to upgrade stew for other reasons than result, doesn't have time to deal with result right now and doesn't want a flood of warnings
arnetheduck
force-pushed
the
graduate-results
branch
from
bdf9f86 to
622fe05
Compare
cheatfate
approved these changes
Jul 4, 2023
tersec
approved these changes
Jul 4, 2023
Since the results package has seen "stable" use for quite a while now, it's as good time a time as any to release 1.0 and migrate it out of stew, thus signalling API stability of some sort. Part of that "stabilization" is underway in the nim-results [issue tracker](arnetheduck/nim-results#30).
arnetheduck
force-pushed
the
graduate-results
branch
from
622fe05 to
b487c86
Compare
arnetheduck
added a commit
to status-im/nimbus-eth2
that referenced
this pull request
Jul 5, 2023
status-im/nim-stew#185 also an assortment of other stew fixes
arnetheduck
added a commit
to status-im/nimbus-eth2
that referenced
this pull request
Jul 5, 2023
status-im/nim-stew#185 also an assortment of other stew fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the results package has seen "stable" use for quite a while now, it's as good time a time as any to release 1.0 and migrate it out of stew, thus signalling API stability of some sort.
Part of that "stabilization" is underway in the nim-results issue tracker.