Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix "top_99_9" not match "/_(top)?\d+$/" #706

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix "top_99_9" not match "/_(top)?\d+$/" #706

wants to merge 1 commit into from

Conversation

chenniannian90
Copy link

replace "top_99_9" to "top_precent"

@chenniannian90
fix "top_99_9" not match "/_(top)?\d+$/"
b7696e5 
replace "top_99_9" to "top_precent"
@chenniannian90
Copy link
Author

fix "top_99_9" not match "/_(top)?\d+$/"

@unitmatrix
Copy link

Consider replacing (\d|_)+ with [0-9_]+ in the matching pattern to make the regular expression more readable and avoid using in this case redundant logical operator and capturing groups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chenniannian90 @unitmatrix