Change deleteIdleStats default value from false to true #516
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Statsd has a deleteIdleStats option that is responsible for removing unused statistics. The default value is false, which means once statsd has seen a stat, it will repeatedly send it forever regardless of weather it sees that stat come in again. I propose a default value of true, which is far less likely to cause harm. In practice, stat names change regularly and I've seen this feature cause more than 500,000 unused, worthless stats to be sent to a single Graphite instance every five seconds without end. Even a well-spec'd Graphite instance can struggle to keep up with that volume of data, especially since that's not including the actual live data that people want. Graphite does not include good facilities for identifying where a given stat comes from so identifying statsd as the source of the flood of stats took many man-hours. Please save many headaches and remove unused stats by default by setting deleteIdleStats to true out of the box.