Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean backends interface #434

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Clean backends interface #434

wants to merge 18 commits into from

Conversation

allevo
Copy link

@allevo allevo commented Jul 17, 2014

Use inheritance to define an interface for backends

Remove global variables.
Remove all jshint warning where possible.
Add graphite utility.

@allevo allevo mentioned this pull request Jul 20, 2014
Closed
@allevo
Copy link
Author

allevo commented Jul 25, 2014

Are you interessed in this pull request?

@mrtazz
Copy link
Member

mrtazz commented Jul 26, 2014

I think removing global vars is definitely a good thing. I'm not sure I get the benefits of the inheritance approach. It seems to add some more boilerplate to creating a new backend. Can you elaborate a bit on the reasoning for this change?

@allevo
Copy link
Author

allevo commented Jul 26, 2014

In this way each backends describe which events are listened.
I've notice all backends have the same attributes like config, logger and startTime variable.
Conceptually all backends are interchangeable. So, the best way to explicit this is inheritance IHMO.
I can remove the inheritance is you disagree.

For the removing all grlobal variable, I'm preparing another pull request to clean stast.js file (https://github.com/allevo/statsd/commits/feature/refactorize-stast). ASAP I'll do pull request if you are interested...

@allevo
Refactorize backend interface
8a5f09e
@allevo
Add fake graphite server for utility
6b7d9be
@allevo
Use new interface in repeater backend
b9373d7
@allevo
Avoid global variables
d3f9528
@allevo
Avoid global variables
9dfb16d
@allevo
Fix prefixStast
cf1f9cf
@allevo
Use ' instead of "
6e6dab6
@allevo
First wrapping to object
294d0b6
@allevo
Avoid global variables
9401b92
@allevo
jshint fixes
e74e77e
@allevo
Refatorize read config
a93f926 
Use method as callback in readConfigFile
Use method ad callback in onUdpPacketReceived
@allevo
Use method as callback in onTcpConnectionActive
952ac53
@allevo
Use method as callback in onTcpPacketReceived
821ae78
@allevo
Use method as callback in onFlushInterval
23c9e59
@allevo
Remove logger as global variable
47d3e59
@allevo
Reformatting with space and without laxcomma
bac52d6
@allevo
Export Statsd and run it only if call directly
7572d7c
@allevo
Remove unused variable and use function to cleanup
a02ca75
@allevo
Copy link
Author

allevo commented Sep 16, 2014

which changes are you interested?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@allevo @mrtazz