Fix V3074, V3114 warnings from PVS-Studio Static Analyzer #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello. I'm a member of the Pinguem.ru competition on finding errors in open source projects. A bug, found using PVS-Studio. Warnings: V3074 The 'ISocket' class contains 'Dispose' method. Consider making it implement 'IDisposable' interface. ISocket.cs 11 V3114 IDisposable object 'memoryStream' is not disposed before method returns. Hybi13Handler.cs 29
mokeev1995
reviewed
Apr 5, 2019
| @@ -8,7 +8,7 @@ | |||
|
|
|||
| namespace Fleck | |||
| { | |||
| public interface ISocket | |||
There was a problem hiding this comment.
I think it might be good idea to remove original Dispose() method from this interface as it exists in IDisposable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. I'm a member of the Pinguem.ru competition on finding errors in
open source projects. A bug, found using PVS-Studio.
Warnings:
V3074 The 'ISocket' class contains 'Dispose' method. Consider making it
implement 'IDisposable' interface. ISocket.cs 11
V3114 IDisposable object 'memoryStream' is not disposed before method
returns. Hybi13Handler.cs 29