Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve switching between plots #20

Open
sgagliano opened this issue Feb 1, 2017 · 3 comments
Open

Improve switching between plots #20

sgagliano opened this issue Feb 1, 2017 · 3 comments

Comments

@sgagliano
Copy link
Collaborator

sgagliano commented Feb 1, 2017

On Manhattan Plot page when you click a variant have an option to go eitherto the LZ page or to the PheWAS page (to make navigation to the PheWAS plot less clunky).

@pjvandehaar
Copy link
Collaborator

pjvandehaar commented Feb 2, 2017

Thanks @sgagliano . What do you think of these options:

  1. When you click a point on the Manhattan plot, you get a tooltip locked in place for that point (like how it happens now on the LZ plot). That tooltip has links to both PheWAS and LZ, so you click one of those. The PheWAS plot would work the same way, linking to both the LZ and Manhattan.

  2. When you're on the Manhattan or PheWAS pages, there's a toggle/switch (like this) in the header that says:

    [ LocusZoom Enabled | LocusZoom Disabled ]

    Maybe I could put a little question-mark-in-a-circle next to it that explained a little more.

  3. When you're on a Manhattan page, there's a toggle right below the Manhattan plot that says:

    Points link to [ LocusZoom plot | PheWAS plot ]

    The PheWAS page would have a similar toggle:

    Points link to [ Manhattan plot | LocusZoom plot ]

I'm favoring option 2.

@sgagliano
Copy link
Collaborator Author

sgagliano commented Feb 2, 2017

Thanks @pjvandehaar

I think either option 1 or 2.
You say you're favouring option 2. Wouldn't you need 2 toggle switches: one for LZ and the other for PheWAS, where only 1 can be switched to "ON" at a time:
ON/OFF [ LocusZoom Enabled | LocusZoom Disabled ]
ON/OFF [ PheWAS Enabled | PheWAS Disabled ]

The "little question-mark-in-a-circle" to explain is definitely a good idea.

@pjvandehaar
Copy link
Collaborator

pjvandehaar commented Feb 3, 2017

all possible behaviors when clicking on a point: (LZ always has "Go to Manhattan Plot")

 Manhattan
 |       ^
 |       |
 V       V
LZ <---> PheWAS

currently:

 Manhattan
 |       ^
 |       |
 V       |
LZ ----> PheWAS

with "LZ disabled":

 Manhattan
         ^
         |
         V
LZ       PheWAS

with "LZ enabled":

 Manhattan
 |       
 |        
 V       
LZ <---> PheWAS

One switch can't do the current behavior but I'm gonna try it and see how it works.

@pjvandehaar pjvandehaar changed the title Switching between plots Improve switching between plots Feb 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants