Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating search box and region view logic #43

Open
amkwong opened this issue Nov 26, 2019 · 3 comments
Open

Updating search box and region view logic #43

amkwong opened this issue Nov 26, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@amkwong
Copy link
Collaborator

amkwong commented Nov 26, 2019

The updates from #42 forces the region view to always have chrom, start, end, tissue, and gene_id, to help preserve and recreate the state of the current view. This leads to a few issues which need to be addressed:

  • Some of the logic for handling missing data for the region_view() in pheget/frontend/init.py are now obsolete and need to be removed

  • We need to update the logic for the search box to smartly handle the following searches:

  1. Single-tissue+chromosome: (need to fill in: best gene -> start and end)
  2. Single-gene (gene_id or symbol): (need to fill in: chrom, best tissue, start and end from the gene)
  3. chrom+start+end: (need to fill in: best tissue, best gene -> start and end)
  • We need to update the searchbox to use the Fetch API to request data from omnisearch instead of the complicated mess it currently uses
@amkwong amkwong added the enhancement New feature or request label Nov 26, 2019
@abought
Copy link
Member

abought commented Nov 27, 2019

I see everyone is assigned. Who should be working on this?

Convention with project boards is toassign no one (open ticket, free to claim) or someone (who is then responsible).

@amkwong
Copy link
Collaborator Author

amkwong commented Nov 27, 2019

We can leave it open at the moment then and see if anyone wants to claim this.

@amkwong
Copy link
Collaborator Author

amkwong commented Feb 14, 2020

#47 rewrote all requests using the Fetch API, and improved some of the search logic.

We still need to address the case in which the user searches for a single variant (chr:pos or rsnum) which cannot be found in our data. Currently, this kind of search leads to an error. I think the most useful way to handle this is to search for the top signal within a +/- 500kb region, then display the gene x tissue region plot containing that top signal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants