Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register payment channels after virtual fund objective is complete #1766

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Register payment channels after virtual fund objective is complete #1766

wants to merge 10 commits into from

Commits on Sep 20, 2023

  1. refactor: encapsulate data for payment channel reg

    Colin Kennedy committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    3a6b78f View commit details
    Browse the repository at this point in the history

  2. add a PaymentChannelToRegister protocol SideEffect

    Colin Kennedy committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    108bb3b View commit details
    Browse the repository at this point in the history

  3. emit request to register payment channel post VFO 

    ... this is overly specified - see
github.com//issues/1750
    Colin Kennedy committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    5ead561 View commit details
    Browse the repository at this point in the history

  4. register payment channel only if a payer or payee

    Colin Kennedy committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    e27be4c View commit details
    Browse the repository at this point in the history

  5. remove forwarding method

    Colin Kennedy committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    53cc55e View commit details
    Browse the repository at this point in the history

  6. remove old payment channel registration calls

    Colin Kennedy committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    3525d89 View commit details
    Browse the repository at this point in the history

  7. add payment channel registration side effect

    Colin Kennedy committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    fd0eb8f View commit details
    Browse the repository at this point in the history

  8. update calls to channel registration

    Colin Kennedy committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    c8184ab View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2023

  1. refactor: use passed startingBalance directly

    Colin Kennedy committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    845e8a1 View commit details
    Browse the repository at this point in the history

  2. add assertion that payment succeeds

    Colin Kennedy committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    71c09a2 View commit details
    Browse the repository at this point in the history