Register payment channels after virtual fund objective is complete #1766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
September 20, 2023 12:26
... this is overly specified - see github.com//issues/1750
👷 Deploy Preview for nitrodocs processing.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the engine, via the voucher manager, was happy to create (oops) and receive (oh no!) vouchers for channels whose status was still in
Proposed.This PR moves channel registration with the voucher manager to be triggered only by the completion of a virtual fund objective. Premature attempts to create or receive a voucher will now error out of the voucher manager.
Closes #1721
Related: #1750. This PR adds still more coupling between VFO and payment channel app, but gives a decent escape hatch - replacing
SideEffects.PaymentChannelToRegisterwith a more genericSideEffects.AppChannelEffectsfield.