This repository has been archived by the owner on Jul 21, 2024. It is now read-only.
Fixed many typos at README.md #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rabits
suggested changes
Aug 3, 2020
| @@ -61,7 +61,7 @@ All the components could be used independently with a browser or curl. | |||
| ### Blender Addon | |||
|
|
|||
| It's integrated with the current Blender render engine and allows user to send the | |||
| same configuration to the Manager to use the cloud resources for rendering. | |||
| the same configuration to the Manager to use the cloud resources for rendering. | |||
| @@ -101,7 +101,7 @@ if there are no tasks for 30 mins (by default). | |||
| Tasks are coming from Addon: one task - one frame. Tasks have a number of samples to | |||
| render - and the Manager decides how many samples it will give to an Agent. The Manager | |||
| tries to keep the ratio loading/rendering relatively lower, but less than 30 mins per | |||
| Agent task. By default it's 100 samples per Agent task. | |||
| Agent task. By default, it's 100 samples per Agent task. | |||
| @@ -142,7 +142,7 @@ pair of user/password - they are stored as Manager configuration. | |||
|
|
|||
| When Addon wants to talk with Manager - it provides credentials in the HTTP request | |||
| header, Manager compares those creds with the stored ones and if they are ok - allow | |||
| the request and respond. | |||
| the request and response. | |||
There was a problem hiding this comment.
Means respond to the request, not "allows both request and response".
| @@ -154,10 +154,10 @@ to encrypt the whole communication between client and server. | |||
|
|
|||
| Required to encrypt the message transport - so no one but client and server can read | |||
| those messages during transmission. That means any communication or transfer between | |||
| Addon & Manager or Manager and Agent is completely encrypted. | |||
| Addon & Manager or Manager and Agent are completely encrypted. | |||
There was a problem hiding this comment.
Communication - is, right? Like in the line 49
| @@ -223,12 +223,12 @@ can see the issues: | |||
|
|
|||
| ### Addon configuration | |||
|
|
|||
| Addon is using provider tools for its configuration. So check that your provider tool is available | |||
| The addon is using provider tools for its configuration. So check that your provider tool is available | |||
| CA and server SSL certificates and shares the CA certificate with Addon. Addon tries to connect the | ||
| Manager using ssl connection and the credentials from configuration (or generated ones). | ||
| A manager using an SSL connection and the credentials from configuration (or generated ones). |
| in your PATH and working correctly: you should be able to create an instance and bucket in the | ||
| default project using the provider tool. | ||
| default project using the provided tool. |
| @@ -241,17 +241,17 @@ can check that using google cloud web console at https://console.cloud.google.co | |||
| * Command `gsutil mb gs://test-bucket-jsfkhbqfhbqw` should create a test bucket | |||
| * Command `gsutil rm -r gs://test-bucket-jsfkhbqfhbqw` should clean and delete the test bucket | |||
|
|
|||
| Of course it's just an example - but in general case those commands should work for you. | |||
| Of course, it's just an example - but in general case those commands should work for you. | |||
|
|
||
| ### Manager instance provisioning | ||
|
|
||
| This action actually uses bucket creation, bucket files upload, instance creation, autostarting | ||
| script that downloads the Manager scripts from bucket and runns them. After that Manager generates | ||
| This action actually uses bucket creation, bucket files upload, instance creation, an autostarting |
There was a problem hiding this comment.
an - probably "and"? So without comma.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.