[5.x] Fix values being wrapped in arrays causing multiple selected options #11630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to appear as a single option in the CMS
simonworkhouse
changed the title
…ch old expectations
|
Any progress on this? Would be super helpful |
|
+1 |
|
Sorry, we don't have an ETA for reviewing/merging this pull request. We'll get to it when we can. In the meantime, you can pull this PR into your project with a composer patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #11333 and the related PR statamic-rad-pack/runway#654 this fix ensures that the
HasSelectOptionsfield type trait correctly casts pre-processed values to an array even if they are collections.This addresses issues caused both when extending a select fieldtype to utilise collections and issues caused by Runway changes where collection values are no longer being cast to arrays.
Fixes #11333
Replaces statamic-rad-pack/runway#654