-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(blockifier_reexecution): add trait consecutive_state_readers #1648
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1648 +/- ##
==========================================
+ Coverage 40.10% 41.88% +1.78%
==========================================
Files 26 193 +167
Lines 1895 22996 +21101
Branches 1895 22996 +21101
==========================================
+ Hits 760 9633 +8873
- Misses 1100 12917 +11817
- Partials 35 446 +411 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aner-starkware and @AvivYossef-starkware)
crates/blockifier_reexecution/src/state_reader/test_state_reader.rs
line 243 at r1 (raw file):
fn get_next_block_state_diff(&self) -> ReexecutionResult<CommitmentStateDiff>; }
please doc this trait (is what I wrote correct?)
Suggestion:
/// Expands on the `StateReader` trait by adding more state-related queries required for reexecution.
pub trait ConsecutiveStateReaders<S: StateReader> {
fn get_transaction_executor(
self,
transaction_executor_config: Option<TransactionExecutorConfig>,
) -> ReexecutionResult<TransactionExecutor<S>>;
fn get_next_block_txs(&self) -> ReexecutionResult<Vec<BlockifierTransaction>>;
fn get_next_block_state_diff(&self) -> ReexecutionResult<CommitmentStateDiff>;
}
f7f08d8
to
ce0cb69
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @dorimedini-starkware)
crates/blockifier_reexecution/src/state_reader/test_state_reader.rs
line 243 at r1 (raw file):
Previously, dorimedini-starkware wrote…
please doc this trait (is what I wrote correct?)
Done.
No description provided.