Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(blockifier_reexecution): add trait consecutive_state_readers #1648

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aner-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.88%. Comparing base (e3165c4) to head (ce0cb69).
Report is 75 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1648      +/-   ##
==========================================
+ Coverage   40.10%   41.88%   +1.78%     
==========================================
  Files          26      193     +167     
  Lines        1895    22996   +21101     
  Branches     1895    22996   +21101     
==========================================
+ Hits          760     9633    +8873     
- Misses       1100    12917   +11817     
- Partials       35      446     +411     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aner-starkware and @AvivYossef-starkware)


crates/blockifier_reexecution/src/state_reader/test_state_reader.rs line 243 at r1 (raw file):

    fn get_next_block_state_diff(&self) -> ReexecutionResult<CommitmentStateDiff>;
}

please doc this trait (is what I wrote correct?)

Suggestion:

/// Expands on the `StateReader` trait by adding more state-related queries required for reexecution.
pub trait ConsecutiveStateReaders<S: StateReader> {
    fn get_transaction_executor(
        self,
        transaction_executor_config: Option<TransactionExecutorConfig>,
    ) -> ReexecutionResult<TransactionExecutor<S>>;

    fn get_next_block_txs(&self) -> ReexecutionResult<Vec<BlockifierTransaction>>;

    fn get_next_block_state_diff(&self) -> ReexecutionResult<CommitmentStateDiff>;
}

@aner-starkware aner-starkware force-pushed the aner/add_consecutive_state_readers_trait branch from f7f08d8 to ce0cb69 Compare October 29, 2024 18:15
Copy link
Contributor Author

@aner-starkware aner-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @dorimedini-starkware)


crates/blockifier_reexecution/src/state_reader/test_state_reader.rs line 243 at r1 (raw file):

Previously, dorimedini-starkware wrote…

please doc this trait (is what I wrote correct?)

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants