Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sdk/dotnet-code_snippets #247

Merged
merged 5 commits into from
Nov 29, 2024
Merged

sdk/dotnet-code_snippets #247

merged 5 commits into from
Nov 29, 2024

Conversation

SpiralOSS
Copy link
Contributor

csharp snippets: multiple_events and setup

@bencroker
Copy link
Collaborator

Your setup.csharpsnippet should mirror what setup.gosnippet is doing. Can you please adjust?

@SpiralOSS
Copy link
Contributor Author

SpiralOSS commented Nov 27, 2024 •
edited
Loading

@bencroker, updated

@bencroker
Copy link
Collaborator

bencroker commented Nov 29, 2024 •
edited
Loading

Thanks for making those changes! Note that the concept of store is going away and being replaced simply by signals in version 0.21.0.

@bencroker bencroker merged commit 26b947b into starfederation:develop Nov 29, 2024
1 check failed
@bencroker
Copy link
Collaborator

Merged, thanks!

@SpiralOSS SpiralOSS deleted the sdk/dotnet-code_snippets branch November 29, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bencroker bencroker bencroker approved these changes

@delaneyj delaneyj Awaiting requested review from delaneyj delaneyj is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SpiralOSS @bencroker @delaneyj