Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix authentication #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

CorentinB
Copy link

Apparently the cookie's name for session auth changed, it's now "_gabsocial_session".

Apparently the cookie's name for session auth changed, it's now "_gabsocial_session"
@milesmcc
Copy link
Collaborator

milesmcc commented Apr 8, 2022

Interestingly, it seems like maybe both are required? When I log into Gab, I see both _gabsocial_session and _session_id being set:

image

image

Is there an error you're running into? I suppose we could update this check to verify both are present.

@CorentinB
Copy link
Author

Hi @milesmcc, I quickly talked with @lxcode about this, it looks like on my end only _gabsocial_session is used, on his, he was only seeing _session_id indeed.

I guess it's more one or the other than both at the same time. We could add a check to see if one of the two is present?

@milesmcc
Copy link
Collaborator

milesmcc commented Apr 8, 2022

That approach makes sense to me! Want to update this PR? I can also just make the push.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants