Prevent double buffering by exposing the BufRead
bound
#100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of a nit, but interfaces that expose
Read
bounds should not do internal buffering, as this risks the caller accidentally passing a type that is already buffered, resulting in double buffering. Instead, by exposing theBufRead
bound the caller is forced to buffer if he tries passing a type that only implementsRead
. Since the caller has better awareness of the code he is writing, he is much less likely to accidentally buffer a reader twice.