feat: get_deposits returns accepted and pending
#1479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jiloc
changed the title
get_deposits returns accepted and pendingget_deposits returns accepted and pending
matteojug
approved these changes
Mar 6, 2025
| fn get_deposits( | ||
| &self, | ||
| ) -> impl std::future::Future<Output = Result<Vec<CreateDepositRequest>, Error>> + Send; | ||
|
|
||
| /// Get pending deposits from Emily. |
Comment on lines
+753
to
+755
| // Check that we get all deposits | ||
| let deposits = emily_client.get_deposits().await.unwrap(); | ||
| assert_eq!(deposits.len(), num_deposits); |
There was a problem hiding this comment.
nit: can we also check that we got num_accepted deposits with an Accepted state?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #1463
Changes
get_deposits->get_deposits_with_status.get_depositsimplementation that returns bothPendingandAccepteddeposits. If only one of the two calls fails, we log an error but still return the deposits fetched by the other call.Testing Information
Checklist: