chore: emily filter updates from signers #1472
Open
+449
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jiloc
added
the
emily
Jiloc
changed the title
matteojug
reviewed
Mar 6, 2025
Comment on lines
+452
to
+454
| if is_unauthorized { | ||
| return Err(Error::Forbidden); | ||
| } |
There was a problem hiding this comment.
Should further limit the signers update to state transition from pending to accepted? Otherwise it could be possible that a signer change a confirmed deposit back to accepted. I looked around but I couldn't find anything preventing this, but maybe I'm missing something.
| (status = 404, description = "Address not found", body = ErrorResponse), | ||
| (status = 405, description = "Method not allowed", body = ErrorResponse), | ||
| (status = 500, description = "Internal server error", body = ErrorResponse) | ||
| ), | ||
| security(("ApiGatewayKey" = [])) | ||
| )] | ||
| #[instrument(skip(context))] | ||
| #[instrument(skip(context, api_key))] |
There was a problem hiding this comment.
nit: should we add the api_key skip also to the other ApiGatewayKey endpoints?
There was a problem hiding this comment.
changed for chainstate endpoints (seems like they were the only ones left) in 4ec3ad7
| let is_unauthorized = body | ||
| .withdrawals | ||
| .iter() | ||
| .any(|deposit| deposit.status != Status::Accepted); |
There was a problem hiding this comment.
nit
Suggested change
| .any(|deposit| deposit.status != Status::Accepted); | |
| .any(|withdrawal| withdrawal.status != Status::Accepted); |
matteojug
reviewed
Mar 6, 2025
| // -------- | ||
| let request_id = 1; | ||
|
|
||
| // Setup test deposit transaction. |
There was a problem hiding this comment.
nit: s/deposit/withdrawal/, multiple occurrences
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #1462
Changes
update_withdrawalsandupdate_depositsnow return 403 Forbidden if an api key of the public api (the signers) is trying to set an entry to a status !=Acceptedupdate_*endpoints.Testing Information
Checklist: