feat: new behavior for network bootstrapping #1257
Open
+615
−131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cylewitruk
added
sbtc signer binary
1 task
4 tasks
matteojug
reviewed
Jan 30, 2025
|
@matteojug I ended up doing quite a bit of refactoring, sorry :( So this probably needs a fresh look. |
matteojug
reviewed
Feb 3, 2025
djordon
modified the milestones:
sBTC: Withdrawal Code Complete,
sBTC: Withdrawal fine tuning
matteojug
approved these changes
Mar 4, 2025
djordon
approved these changes
Mar 5, 2025
| .map(|either, _| either.into_inner()) | ||
| .boxed(); | ||
| } | ||
| let tcp_config = tcp::Config::default().nodelay(true); |
There was a problem hiding this comment.
What is the significance of the nodelay here.
There was a problem hiding this comment.
It disables Nagle's Algorithm on the socket which is enabled by default on most OS's. I think this option might be set by default now, but I added it explicitly to be, well, explicit as to our intentions.
| .map_err(|e| SignerSwarmError::LibP2P(Box::new(e)))?; | ||
| } | ||
| { | ||
| let mut swarm = self.swarm.lock().await; |
There was a problem hiding this comment.
We just locked, and unlock the swarm a moment ago for the local_peer_id. Maybe we should move that log down here.
| enable_quic_transport: false, | ||
| enable_memory_transport: false, | ||
| initial_bootstrap_delay: Duration::from_secs(0), |
There was a problem hiding this comment.
nit: this could be Duration::ZERO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #1133
Changes
Testing Information
Existing tests pass and I've tested this quite a bit in
devenv. I'll add some actual tests for the behavior, but PR'ing this now for preview.Checklist: