Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update sBTC best practices #1709

Merged
merged 18 commits into from
Mar 6, 2025
Merged

Conversation

aldur
Copy link
Contributor

@aldur aldur commented Feb 26, 2025

Description

Describe the changes that were made in this pull request. When possible start with the motivations behind the change.

@aldur aldur requested a review from a team as a code owner February 26, 2025 10:35
@aldur aldur marked this pull request as draft February 26, 2025 10:35
Copy link
Member

@cylewitruk cylewitruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm in general for this revision, just had a few suggestions.

@aldur aldur marked this pull request as ready for review March 6, 2025 14:16
@aldur aldur enabled auto-merge (squash) March 6, 2025 14:28
Copy link
Collaborator

@BowTiedDevOps BowTiedDevOps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nits, looking good otherwise

Copy link
Collaborator

@BowTiedDevOps BowTiedDevOps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@aldur aldur merged commit e1141d9 into master Mar 6, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants