-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update sBTC best practices #1709
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm in general for this revision, just had a few suggestions.
guides-and-tutorials/sbtc/best-practices-for-running-an-sbtc-signer.md
Outdated
Show resolved
Hide resolved
guides-and-tutorials/sbtc/best-practices-for-running-an-sbtc-signer.md
Outdated
Show resolved
Hide resolved
guides-and-tutorials/sbtc/best-practices-for-running-an-sbtc-signer.md
Outdated
Show resolved
Hide resolved
…igner.md Co-authored-by: Cyle Witruk <[email protected]>
…igner.md Co-authored-by: Cyle Witruk <[email protected]>
guides-and-tutorials/sbtc/best-practices-for-running-an-sbtc-signer.md
Outdated
Show resolved
Hide resolved
…igner.md Co-authored-by: Cyle Witruk <[email protected]>
guides-and-tutorials/sbtc/best-practices-for-running-an-sbtc-signer.md
Outdated
Show resolved
Hide resolved
guides-and-tutorials/sbtc/best-practices-for-running-an-sbtc-signer.md
Outdated
Show resolved
Hide resolved
guides-and-tutorials/sbtc/best-practices-for-running-an-sbtc-signer.md
Outdated
Show resolved
Hide resolved
guides-and-tutorials/sbtc/best-practices-for-running-an-sbtc-signer.md
Outdated
Show resolved
Hide resolved
…igner.md Co-authored-by: Cyle Witruk <[email protected]>
…igner.md Co-authored-by: Cyle Witruk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nits, looking good otherwise
guides-and-tutorials/sbtc/best-practices-for-running-an-sbtc-signer.md
Outdated
Show resolved
Hide resolved
guides-and-tutorials/sbtc/best-practices-for-running-an-sbtc-signer.md
Outdated
Show resolved
Hide resolved
guides-and-tutorials/sbtc/best-practices-for-running-an-sbtc-signer.md
Outdated
Show resolved
Hide resolved
guides-and-tutorials/sbtc/best-practices-for-running-an-sbtc-signer.md
Outdated
Show resolved
Hide resolved
guides-and-tutorials/sbtc/best-practices-for-running-an-sbtc-signer.md
Outdated
Show resolved
Hide resolved
guides-and-tutorials/sbtc/best-practices-for-running-an-sbtc-signer.md
Outdated
Show resolved
Hide resolved
…igner.md Co-authored-by: BowTiedDevOps <[email protected]>
…igner.md Co-authored-by: BowTiedDevOps <[email protected]>
…igner.md Co-authored-by: BowTiedDevOps <[email protected]>
…igner.md Co-authored-by: BowTiedDevOps <[email protected]>
…igner.md Co-authored-by: BowTiedDevOps <[email protected]>
…igner.md Co-authored-by: BowTiedDevOps <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Description
Describe the changes that were made in this pull request. When possible start with the motivations behind the change.