Add cost tracking code #617
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ureeves
force-pushed
the
clarity-cost-tracking
branch
2 times, most recently
from
4c52db3 to
8ad1f2e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #617 +/- ##
==========================================
- Coverage 85.67% 85.05% -0.63%
==========================================
Files 46 47 +1
Lines 24596 24880 +284
Branches 24596 24880 +284
==========================================
+ Hits 21073 21161 +88
- Misses 1673 1816 +143
- Partials 1850 1903 +53 ☔ View full report in Codecov by Sentry. |
ureeves
force-pushed
the
clarity-cost-tracking
branch
4 times, most recently
from
f6dd597 to
7a57232
Compare
Code generated for the `concat` word is changed to ensure both its arguments are traversed *before* copying their contents onto the resulting sequence. This avoids a partially copied to return buffer should the code fail during resolution of the second argument. It will also allow for a cleaner implementation of cost tracking since we can then also avoid copying on a cost overrun. See-also: #616
ureeves
force-pushed
the
clarity-cost-tracking
branch
from
2182389 to
4e24931
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #616