Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support sssd and sshd in compute-init #571

Merged
merged 15 commits into from
Feb 14, 2025
Merged

Support sssd and sshd in compute-init #571

merged 15 commits into from
Feb 14, 2025
+66 −4

Conversation

bertiethorpe
Copy link
Member

No description provided.

@bertiethorpe bertiethorpe force-pushed the feat/sssd-sshd-compute-init branch from 49439f2 to 9c29df9 Compare February 12, 2025 16:34
@bertiethorpe bertiethorpe marked this pull request as ready for review February 13, 2025 13:49
@bertiethorpe bertiethorpe requested a review from a team as a code owner February 13, 2025 13:49
sjpb
sjpb requested changes Feb 13, 2025
View reviewed changes
Copy link
Collaborator

@sjpb sjpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think logic/guarding of tasks needs revising

ansible/roles/sssd/tasks/export.yml Outdated Show resolved Hide resolved
ansible/roles/compute_init/tasks/export.yml Show resolved Hide resolved
ansible/roles/compute_init/tasks/export.yml Show resolved Hide resolved
ansible/roles/sshd/tasks/export.yml Outdated Show resolved Hide resolved
ansible/roles/compute_init/files/compute-init.yml Show resolved Hide resolved
ansible/roles/compute_init/files/compute-init.yml Show resolved Hide resolved
@bertiethorpe bertiethorpe requested a review from sjpb February 13, 2025 17:18
sjpb
sjpb requested changes Feb 14, 2025
View reviewed changes
Copy link
Collaborator

@sjpb sjpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah much cleaner, one logic error!

ansible/roles/compute_init/files/compute-init.yml Outdated Show resolved Hide resolved
@bertiethorpe bertiethorpe requested review from sjpb and jovial February 14, 2025 10:41
sjpb
sjpb requested changes Feb 14, 2025
View reviewed changes
environments/.stackhpc/tofu/main.tf Outdated Show resolved Hide resolved
@bertiethorpe bertiethorpe force-pushed the feat/sssd-sshd-compute-init branch from d5348f7 to 026fce1 Compare February 14, 2025 10:52
@sjpb sjpb changed the title Support sssd and sshd for compute-init Support sssd and sshd in compute-init Feb 14, 2025
@bertiethorpe bertiethorpe requested a review from sjpb February 14, 2025 10:55
sjpb
sjpb approved these changes Feb 14, 2025
View reviewed changes
Copy link
Collaborator

@sjpb sjpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjpb sjpb merged commit 8b1c94c into main Feb 14, 2025
0 of 2 checks passed
@sjpb sjpb deleted the feat/sssd-sshd-compute-init branch February 14, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjpb sjpb sjpb approved these changes

@jovial jovial Awaiting requested review from jovial

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bertiethorpe @jovial @sjpb