Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add flavor to project mapping #52

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

GregWhiteyBialas
Copy link

This will add ability to map flavours to projects in Openstack.
It uses capabilities provided by module: https://github.com/openstack/ansible-collections-openstack/blob/master/plugins/modules/compute_flavor_access.py

Copy link
Member

@cityofships cityofships left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, could you expand README for the role with the additional functionality?

@GregWhiteyBialas
Copy link
Author

I have added some info to readme. Let me know if this is enough.

roles/os_flavors/README.md Outdated Show resolved Hide resolved
Copy link
Author

@GregWhiteyBialas GregWhiteyBialas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interface: "{{ os_flavors_interface | default(omit, true) }}"
name: "{{ item.0.name }}"
state: "{{ item.0.state | default('present') }}"
project: "{{ item.1 | default(omit) }}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does look like it is still possible to have is_public: True and a list of projects for flavor access. Perhaps you should add a predicate based on item.0.is_public here to make sure we only process flavors that are marked as private.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants