Skip to content

feat: Add generic database connection mechanism#1163

Open
sbernauer wants to merge 23 commits intomainfrom
spike/generic-databases
Open

feat: Add generic database connection mechanism#1163
sbernauer wants to merge 23 commits intomainfrom
spike/generic-databases

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented Mar 2, 2026 •
edited
Loading

Description

Part of stackabletech/issues#238

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added

@sbernauer sbernauer mentioned this pull request Mar 2, 2026
Open
@sbernauer sbernauer mentioned this pull request Mar 4, 2026
Open
19 tasks
@sbernauer sbernauer marked this pull request as ready for review March 4, 2026 14:23
sbernauer
sbernauer commented Mar 4, 2026
View reviewed changes
crates/stackable-operator/src/databases/drivers/celery.rs
#[derive(Clone, Debug, Deserialize, JsonSchema, PartialEq, Serialize)]
#[serde(rename_all = "camelCase")]
pub struct GenericCeleryDatabaseConnection {
/// The name of the Secret that contains an `uri` key with the complete SQLAlchemy URI.
Copy link
Member Author

@sbernauer sbernauer Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copied over from https://github.com/stackabletech/airflow-operator/pull/743/changes#r2786318061:

I feel URI is very generic. I think connectionString is a better description?

sbernauer
sbernauer commented Mar 4, 2026
View reviewed changes
@sbernauer sbernauer requested review from Techassi and removed request for Techassi March 19, 2026 11:45
@sbernauer sbernauer requested review from a team and maltesander March 19, 2026 11:45
@sbernauer sbernauer self-assigned this Mar 19, 2026
@sbernauer sbernauer moved this to Development: Waiting for Review in Stackable Engineering Mar 19, 2026
@Techassi Techassi self-requested a review March 19, 2026 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maltesander maltesander Awaiting requested review from maltesander

@Techassi Techassi Awaiting requested review from Techassi

At least 1 approving review is required to merge this pull request.

Assignees

@sbernauer sbernauer

Labels

None yet

Projects

Stackable Engineering
Status: Development: Waiting for Review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sbernauer