Allow writing either GeoParquet 1.0 or GeoParquet 1.1 schema metadata #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gadomski
reviewed
Jun 18, 2024
There was a problem hiding this comment.
I'm not sure, but is there more work to be done w/ the type of the bbox data themselves? Over in stac-utils/stac-rs#256 I was finding that I couldn't even read data that had been written in 1.1.0-dev format if I was expecting 1.0.0 ... but maybe that was just down to the metadata (I'm new to arrow/parquet so my understanding is incomplete).
TomAugspurger
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
schema_versionargument that decides whether or not GeoParquet 1.1-specific metadata should be included in the written file.Note that the exact keyword arg
schema_versionwas chosen to match the parameter name in GeoPandas'to_parquet.Fixes #60
cc @gadomski